New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peaks v1.1 #2

Open
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@boourns

boourns commented Jul 14, 2017

@timchurches

This ports v1.1 of peaks code to Peaks DMC.
I started with the code from @johnfolkesson's branch, and then applied pichenettes/eurorack@26f0ec7

  • fixed the rejects
  • made similar changes to the other processors
  • tested and fixed the algorithms I broke in the process

At this point I've tested all the DMC functionality in Twin mode, but not split or expert. Also, I mostly tested just Ch1.

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Jul 17, 2017

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

Currently this PR has the stmlib bump (last commit, just added)

boourns commented Jul 17, 2017

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

Currently this PR has the stmlib bump (last commit, just added)

@timchurches

This comment has been minimized.

Show comment
Hide comment
@timchurches

timchurches Jul 17, 2017

Owner
Owner

timchurches commented Jul 17, 2017

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Jul 17, 2017

boourns commented Jul 17, 2017

@timchurches

This comment has been minimized.

Show comment
Hide comment
@timchurches

timchurches Jul 17, 2017

Owner
Owner

timchurches commented Jul 17, 2017

@timchurches

This comment has been minimized.

Show comment
Hide comment
@timchurches

timchurches Jul 17, 2017

Owner

Here we are: hi-hat samples recorded for DMC, already down-sampled, plus a demo of them in a loop.

loop1.m4a.zip

downsample.zip

Need to credit Michael Brawer with doing these, but they are unencumbered and free for use in DMC.

Owner

timchurches commented Jul 17, 2017

Here we are: hi-hat samples recorded for DMC, already down-sampled, plus a demo of them in a loop.

loop1.m4a.zip

downsample.zip

Need to credit Michael Brawer with doing these, but they are unencumbered and free for use in DMC.

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Jul 17, 2017

I opened an issue describing the sample player I've got in mind as I won't be adding it to this PR, I'm interested in your thoughts.

boourns commented Jul 17, 2017

I opened an issue describing the sample player I've got in mind as I won't be adding it to this PR, I'm interested in your thoughts.

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Aug 25, 2017

@timchurches IMO this PR should get merged and shipped soon as it fixes the bugs discussed in the muffwiggler thread where the CPU lags and the LFOs mess up

The sample player can sit as a PR for now as (IMO) it could use better samples than what I've managed to put together. It's worth a play though.

boourns commented Aug 25, 2017

@timchurches IMO this PR should get merged and shipped soon as it fixes the bugs discussed in the muffwiggler thread where the CPU lags and the LFOs mess up

The sample player can sit as a PR for now as (IMO) it could use better samples than what I've managed to put together. It's worth a play though.

@timchurches

This comment has been minimized.

Show comment
Hide comment
@timchurches

timchurches Aug 25, 2017

Owner

Ok, thanks, will review it tonight.

Owner

timchurches commented Aug 25, 2017

Ok, thanks, will review it tonight.

@johnfolkesson

This comment has been minimized.

Show comment
Hide comment
@johnfolkesson

johnfolkesson Aug 31, 2017

Hey just to let you guys know I´m running the code from my original PR on 2 different peaks and everything appears to be working just fine.

johnfolkesson commented Aug 31, 2017

Hey just to let you guys know I´m running the code from my original PR on 2 different peaks and everything appears to be working just fine.

@boourns boourns referenced this pull request Oct 15, 2017

Open

Peaks add calibration #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment