use name instead of id (BREAKING!) #10

timelyportfolio · 2016-12-05T03:30:50Z

As I integrate d3_nest with more functions, I realize that many of the examples use id to imply uniqueness and name without implicit uniqueness. Rework id to name to avoid this potential confusion. Later, I will open a different issue to allow custom key for name and children.

timelyportfolio closed this in 1f07a88 Dec 5, 2016

timelyportfolio added a commit that referenced this issue Dec 5, 2016

fix bug introduced in 5787e03 and change "id" to "name"; closes #10

Loading status checks…

ddc94dc

timelyportfolio added a commit that referenced this issue Dec 5, 2016

update hierarchy test for "name" instead of "id"; see #10

Loading status checks…

4a1f191

timelyportfolio / d3r

use name instead of id (BREAKING!) #10

use name instead of id (BREAKING!) #10

timelyportfolio commented Dec 5, 2016 •

edited

timelyportfolio / d3r

Join GitHub today

use name instead of id (BREAKING!) #10

use name instead of id (BREAKING!) #10

Comments

timelyportfolio commented Dec 5, 2016 • edited

Essential cookies

Always active

Analytics cookies

timelyportfolio commented Dec 5, 2016 •

edited