disable edit when onEdit==FALSE

[sambaala]

Hello,
In the current version, when onEdit=T, the edit icon stays on the view, but it cannot be edited. When onEdit=F, it can be edited. It is the same beharvior for onDelete, onAdd and OnSelect. Is it an issue? Things seems inverted on the following lines

listviewer/inst/htmlwidgets/reactjson.js

Lines 33 to 36 in 107e5cb

	onEdit: x.onEdit ? x.onEdit : function(value) {logChange(value,"edit")},
	onAdd: x.onAdd ? x.onAdd : function(value) {logChange(value,"add")},
	onDelete: x.onDelete ? x.onDelete : function(value) {logChange(value,"delete")},
	onSelect: x.onSelect ? x.onSelect : function(value) {logChange(value,"select")},

.
Regards,
Alassane

[timelyportfolio]

@sambaala thanks so much for posting this. I think there might be some confusion around the on* props which are the callback functions when an event occurs and the currently missing (in listviewer) props controlling whether edit, add, etc. are enabled. I will add these props, and I think the problem will be solved.

[timelyportfolio]

@sambaala never mind I see what you are saying. I like your change and will go with that, and then I will try to clarify in the documentation. Thanks!!