New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bower.json to fix archieml dependency #12

Merged
merged 1 commit into from Sep 23, 2015

Conversation

Projects
None yet
2 participants
@phillipadsmith
Contributor

phillipadsmith commented Sep 3, 2015

This stumped me for an hour:

Using the current version of doctop and the provided archieml.js dependency (0.1.1), arrays were not being returned properly, e.g.:
https://jsfiddle.net/phillipadsmith/nzxhvpjn/

However, updating to archieml.js 0.3.1 returned the expected results:
http://jsfiddle.net/phillipadsmith/ov16Leoh/

Given that archieml is a dependency for using the ArchieML parsing, I would propose updating the dependency! :)

Hope this helps.

Update bower.json to fix archieml dependency
This stumped me for an hour:

Using the current version of doctop and the provided archieml.js dependency (0.1.1), arrays were not being returned properly, e.g.:
https://jsfiddle.net/phillipadsmith/nzxhvpjn/

However, updating to archieml.js 0.3.1 returned the expected results:
http://jsfiddle.net/phillipadsmith/ov16Leoh/

Given that archieml is a dependency for using the ArchieML parsing, I would propose updating the dependency! :)

Hope this helps.
@aendrew

This comment has been minimized.

Show comment
Hide comment
@aendrew

aendrew Sep 23, 2015

Contributor

Does ArchieML still not have a bower.json? For shame! 😄

That's brilliant, thank you very much for looking into that! Merging! 👍 :shipit:

Contributor

aendrew commented Sep 23, 2015

Does ArchieML still not have a bower.json? For shame! 😄

That's brilliant, thank you very much for looking into that! Merging! 👍 :shipit:

aendrew added a commit that referenced this pull request Sep 23, 2015

Merge pull request #12 from phillipadsmith/patch-1
Update bower.json to fix archieml dependency

@aendrew aendrew merged commit bb3f7d2 into times:master Sep 23, 2015

@phillipadsmith

This comment has been minimized.

Show comment
Hide comment
@phillipadsmith

phillipadsmith Sep 23, 2015

Contributor

Does ArchieML still not have a bower.json? For shame!

Ha! Good point. I'll check and report something there if that's still the case. 👍

Contributor

phillipadsmith commented Sep 23, 2015

Does ArchieML still not have a bower.json? For shame!

Ha! Good point. I'll check and report something there if that's still the case. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment