Skip to content

Conversation

@syvb
Copy link
Member

@syvb syvb commented Dec 15, 2022

Description

Documents all of the changes made to state_agg and timeline_agg (including the new support for integer states and rollup) in TimescaleDB Toolkit 1.13.

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-sv-state_agg-1.13

@syvb syvb force-pushed the sv/state_agg-1.13 branch from 8ae55e8 to 1561931 Compare December 15, 2022 23:43
@syvb syvb marked this pull request as ready for review December 16, 2022 00:15
@Loquacity Loquacity requested a review from charislam December 16, 2022 06:07
GROUP BY time_bucket('1 minute', ts))
SELECT toolkit_experimental.duration_in(
'START',
toolkit_experimental.rollup(buckets.sa)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: does this actually roll up multiple buckets? Or is it just rolling up a single bucket into the same single bucket?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and verified that with my testing data it does split up the data into three buckets and roll them up.

@syvb syvb force-pushed the sv/state_agg-1.13 branch from 1561931 to 1de4d6d Compare December 19, 2022 14:20
@syvb syvb requested a review from charislam December 19, 2022 15:16
@syvb syvb force-pushed the sv/state_agg-1.13 branch from 9f6c29c to 57d4c7a Compare December 20, 2022 16:47
@syvb syvb merged commit a472264 into latest Dec 20, 2022
@syvb syvb deleted the sv/state_agg-1.13 branch December 20, 2022 17:01
WireBaron pushed a commit that referenced this pull request Dec 20, 2022
* Document changes to state_agg/timeline_agg in Toolkit 1.13

* fix lacking mention of TimelineAgg

* Use better examples for state_agg changes

* Expand on use cases for integer states
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants