Merged
Conversation
syvb
force-pushed
the
sv/fix-page-overuse
branch
from
ae9c87c to
92068a6
Compare
syvb
force-pushed
the
sv/fix-page-overuse
branch
2 times, most recently
from
2183545 to
d69e95d
Compare
cevian
requested changes
Nov 5, 2024
Collaborator
cevian
left a comment
cevian
left a comment
There was a problem hiding this comment.
Looks good. Some changes requested
Collaborator
|
Also can you describe the problem a bit more in the commit msg |
syvb
force-pushed
the
sv/fix-page-overuse
branch
3 times, most recently
from
0574e5e to
7e8dc75
Compare
cevian
previously approved these changes
Nov 5, 2024
syvb
force-pushed
the
sv/fix-page-overuse
branch
from
7e8dc75 to
42507fc
Compare
Currently, `insert_storage` in the access method creates a new Tape to add the vector to, on every insert. This can cause a lot of empty space in pages. This commit allows tapes to be resumed at the most recent block (of the right tape), instead of always starting at a new block. This allows `insert_storage` to continue writing into an existing page instead of creating a new one.
syvb
force-pushed
the
sv/fix-page-overuse
branch
from
42507fc to
10ce42e
Compare
Signed-off-by: Smitty <smitty@timescale.com>
cevian
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.