Skip to content

Verify cargo fmt in CI: part 1#533

Merged
bors[bot] merged 1 commit intomainfrom
sv/verify-rustfmt-ci
Sep 14, 2022
Merged

Verify cargo fmt in CI: part 1#533
bors[bot] merged 1 commit intomainfrom
sv/verify-rustfmt-ci

Conversation

@syvb
Copy link
Copy Markdown
Contributor

@syvb syvb commented Sep 13, 2022

Updates the Docker image so that later the CI will be able to verify everything is formatted with rustfmt.

@syvb syvb force-pushed the sv/verify-rustfmt-ci branch from abbc722 to b35fad9 Compare September 14, 2022 16:52
@syvb syvb changed the title Verify cargo fmt in CI Verify cargo fmt in CI: part 1 Sep 14, 2022
@syvb syvb marked this pull request as ready for review September 14, 2022 16:56
@syvb syvb force-pushed the sv/verify-rustfmt-ci branch 2 times, most recently from f2293a2 to b7da544 Compare September 14, 2022 17:03
@syvb
Copy link
Copy Markdown
Contributor Author

syvb commented Sep 14, 2022

The "Build CI Image" failure can be ignored, it always tries to login to Docker Hub but fails because some PRs don't have access to secrets. (and bors doesn't treat it as a mandatory check)

@syvb
Copy link
Copy Markdown
Contributor Author

syvb commented Sep 14, 2022

bors r+

@epgts
Copy link
Copy Markdown
Contributor

epgts commented Sep 14, 2022

The "Build CI Image" failure can be ignored, it always tries to login to Docker Hub but fails because some PRs don't have access to secrets. (and bors doesn't treat it as a mandatory check)

Are we sure it's not mandatory?

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Sep 14, 2022

@bors bors Bot merged commit a322209 into main Sep 14, 2022
@bors bors Bot deleted the sv/verify-rustfmt-ci branch September 14, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants