Skip to content

Deduplicate version number #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Sep 26, 2022
Merged

Deduplicate version number #542

bors merged 2 commits into from
Sep 26, 2022

Conversation

@syvb
Copy link
Contributor

@syvb syvb commented Sep 21, 2022 •
edited
Loading

We don't use the version number in the extension's Cargo.toml anywhere currently. pgx supports replacing @CARGO_VERSION@ in control files, so use that.

@syvb syvb requested review from WireBaron and epgts September 21, 2022 16:31
epgts
epgts reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pgx supports replacing @CARGO_VERSION@ in control files but we don't use that in our control file.

Interesting. Should we? Would that allow us to have only one place to update the version number and that places is extension/Cargo.toml ? If so, I think I like that.

@WireBaron
Copy link
Contributor

WireBaron commented Sep 21, 2022

pgx supports replacing @CARGO_VERSION@ in control files but we don't use that in our control file.

Interesting. Should we? Would that allow us to have only one place to update the version number and that places is extension/Cargo.toml ? If so, I think I like that.

The problem is that we still have to update the control file to update the upgrade version, so I'm not sure it buys us that much. Is there anywhere else we can make use of this @CARGO_VERSION@? Let's discuss tomorrow.

@syvb syvb force-pushed the sv/rm-unused-version branch from 7f95081 to 373b597 Compare September 23, 2022 15:39
@syvb syvb changed the title Make unused version number 0.0.0-unused Deduplicate version number Sep 23, 2022
@syvb syvb force-pushed the sv/rm-unused-version branch from 6d45089 to 6531917 Compare September 23, 2022 17:24
@syvb
Fix how update-tester gets the current version
68a8c08 
The post-install script doesn't need updating since it reads a control
file generated by pgx.
@syvb syvb force-pushed the sv/rm-unused-version branch from 6531917 to 68a8c08 Compare September 23, 2022 17:30
@syvb
Copy link
Contributor Author

syvb commented Sep 23, 2022

I updated the PR to use Cargo.toml as the source for the version number, and updated update-tester to use the new source.

@syvb syvb requested a review from epgts September 23, 2022 17:37
@syvb
Copy link
Contributor Author

syvb commented Sep 26, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 26, 2022

Build succeeded:

@bors bors bot merged commit 4103469 into main Sep 26, 2022
@bors bors bot deleted the sv/rm-unused-version branch September 26, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WireBaron WireBaron Awaiting requested review from WireBaron

1 more reviewer

@epgts epgts epgts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syvb @WireBaron @epgts