Make interpolation errors more user friendly#545
Merged
Conversation
rtwalker
reviewed
Sep 28, 2022
rtwalker
approved these changes
Sep 29, 2022
Contributor
rtwalker
left a comment
rtwalker
left a comment
There was a problem hiding this comment.
LGTM! Might be worth dropping the github generated commit since it seems to be playing weirdly with our CI.
Contributor
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 29, 2022
545: Make interpolation errors more user friendly r=Smittyvb a=Smittyvb Currently the error message for invalid interpolation bounds doesn't make it clear what the issue is, and doesn't say what the expected value is. This PR makes the bound checking assertions more clear Co-authored-by: Smitty <smitty@timescale.com>
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the error message for invalid interpolation bounds doesn't make it clear what the issue is, and doesn't say what the expected value is. This PR makes the bound checking assertions more clear