Basic test for space saving aggregate serialization #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epgts
approved these changes
Oct 5, 2022
Contributor
epgts
left a comment
epgts
left a comment
There was a problem hiding this comment.
Something is certainly better than nothing :)
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on #547 that we don't have any tests for
SpaceSavingAggregates. This PR adds a simple test to verify that theraw_freq_aggfunction will at least run without failing.This test currently fails on #547, which is good since that PR causes a bug that leads to
SpaceSavingAggregatenot working at all.