Conversation
epgts
approved these changes
Oct 17, 2022
Contributor
Author
|
The CI passes on #571 with this PR's Docker image: https://github.com/timescale/timescaledb-toolkit/actions/runs/3266892912/jobs/5371291553 bors r+ |
Contributor
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Oct 17, 2022
547: Upgrade to pgx 0.5.0 r=Smittyvb a=Smittyvb Upgrades to pgx `0.5.0-beta.1` (0.5.0 will hopefully be released in 0-7 days). I originally tested on another branch with a lot of code commented out; this branch cherry picks the commits that fix errors but not the ones that comment code out. To do: - [x] Fix the three failing tests in `datum_utils.rs` (pgcentralfoundation/pgrx#740) - [x] Remove workaround for lack of `Copy` on some types - [x] Make update tester work in CI (#552) - [x] Change pgx version from 0.5.0-beta.1 to 0.5.0 - [ ] Publish new CI docker image with pgx 0.5.0 right before merging (#571) Future work: - Replace `use pgx::*` with `use pgx::prelude::*` - Use native pgx types instead of `crate::raw` - Use `#[pg_aggregate]` instead of our own aggregate builder macro Co-authored-by: Smitty <smitty@timescale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgx 0.5.0 just released! This PR updates the CI to have pgx 0.5.0 and adds pgx 0.5.0 to the
$PATHinstead of pgx 0.4.5.This PR should be merged right before merging #547 so that the CI can pass on that PR before merging it.