Skip to content

Make stats_agg::M3/M4 modules instead of structs #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 9, 2022
Merged

Make stats_agg::M3/M4 modules instead of structs #602

bors merged 1 commit into from
Nov 9, 2022

Conversation

@syvb
Copy link
Contributor

@syvb syvb commented Nov 7, 2022

Makes M3 and M4 in the stats-agg crate modules instead of empty structs, which is more idiomatic.

@syvb
Make m3/m4 modules instead of structs
76fbb69 
This is more idiomatic.
@syvb syvb requested a review from WireBaron November 7, 2022 20:37
@syvb syvb changed the title Make M3/M4 modules instead of structs Make stats_agg::M3/M4 modules instead of structs Nov 7, 2022
@syvb
Copy link
Contributor Author

syvb commented Nov 9, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 9, 2022

Build succeeded:

@bors bors bot merged commit 7c690d7 into main Nov 9, 2022
@bors bors bot deleted the sv/m3-m4-module branch November 9, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WireBaron WireBaron Awaiting requested review from WireBaron

1 more reviewer

@rtwalker rtwalker rtwalker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syvb @rtwalker