Add tests for errors in map_series mapping function #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
changed the title
epgts
approved these changes
Nov 16, 2022
| } | ||
|
|
||
| #[pg_test] | ||
| #[should_panic = "division by zero"] |
Contributor
There was a problem hiding this comment.
Interesting. For some reason, we thought we had to use #[pg_test(error = "...")] and we could not get that to work under github actions even though it works locally on mac and linux. I'll have a look at resurrecting all those disabled tests...
Contributor
Author
There was a problem hiding this comment.
Support for more test attributes is new in 0.5.0 – I'm surprised it ever worked prior to 0.5.0.
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgx 0.6.0 will make some changes to error handling that will affect how the
map_seriespipeline function works. This PR adds some tests to verify thatmap_seriesbehaves correctly when the mapping function throws an error or returnsNULL.