-
Notifications
You must be signed in to change notification settings - Fork 64
Support rollup and integer states state/timeline aggs #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d0ed0f to
41ff3dd
Compare
8171f41 to
1e97905
Compare
4832e02 to
eda09f5
Compare
Merged
WireBaron
reviewed
Dec 5, 2022
d2e6721 to
ad5fd1d
Compare
WireBaron
approved these changes
Dec 6, 2022
Contributor
WireBaron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the inputs to the trans function all below to the aggregate context so shouldn't need to be cloned.
4997c37 to
327e22e
Compare
1aa764b to
0e06731
Compare
epgts
approved these changes
Dec 6, 2022
327e22e to
33dc255
Compare
0e06731 to
9aaeb3c
Compare
Signed-off-by: Smittyvb <smitty@timescale.com>
9aaeb3c to
35b1fe3
Compare
Member
Author
|
bors r+ |
Contributor
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollupforstate_aggandtimeline_agg.state_aggandtimeline_agg. An aggregate can have integer states or string states, but not both. For a few functions this would mean having two functions with the same argument types but differing return types, so in that case I made a separate function for integer-valued aggregates (e.g.state_int_timeline).Ideally this should have been two separate PRs, but my changes to
rollupand the rest of thestate_aggcode have become intertwined.(this should be merged after #636)