Document rollup internals #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/rollup-notes
branch
from
d1ff385 to
554642b
Compare
WireBaron
reviewed
Dec 5, 2022
WireBaron
approved these changes
Dec 6, 2022
Contributor
|
I believe that the scope of this pattern extends beyond Also it's probably outside the scope of this PR, but I think it would be helpful for us to eventually include a treatment of why this is preferable to ordered set aggregates. |
rtwalker
approved these changes
Dec 16, 2022
I took a first pass at a longer explanation with a bit more context around this choice. Signed-off-by: davidkohn88 <35269003+davidkohn88@users.noreply.github.com>
WireBaron
reviewed
Feb 4, 2023
WireBaron
approved these changes
Feb 4, 2023
Co-authored-by: Brian Rowe <brian@timescale.com> Signed-off-by: Smittyvb <me@smitop.com>
Contributor
Author
|
Looks like I forgot to merge this earlier. bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for some implementation details of
rollup.