Fix locale issue on Enterprise Linux systems #656
Merged
Conversation
epgts
reviewed
Dec 13, 2022
| { | ||
| "LC_COLLATE 'C.UTF-8' LC_CTYPE 'C.UTF-8'" | ||
| } | ||
| _ => "LC_COLLATE 'C' LC_CTYPE 'C'", |
Contributor
There was a problem hiding this comment.
This does fix on rocky 8 (about to test all systems), but now that I see that C works, why don't we use that everywhere? I thought we required utf-8 for some reason.
But C is the one locale guaranteed to work.
I'm testing everything with this now:
let locale_flags = "LC_COLLATE 'C' LC_CTYPE 'C'";
Thanks!
Contributor
There was a problem hiding this comment.
sigh:
thread 'main' panicked at 'could not create db
original_update_tests_1.12.1 due to db error: ERROR: new
collation (C) is incompatible with the collation of the template
database (C.UTF-8)
Contributor
There was a problem hiding this comment.
(which is to say, 'just use C everywhere' is no good: trying your branch everywhere now)
Contributor
Author
There was a problem hiding this comment.
Just to note: the code is like this because it needs to use the same method as this code from pgx.
epgts
approved these changes
Dec 13, 2022
Contributor
epgts
left a comment
epgts
left a comment
There was a problem hiding this comment.
Looks good on centos7, rocky8, debian1[01], ubuntu{18,20,22}.04
Thanks!
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(currently untested)