Skip to content

Require all CI jobs to pass, not one #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Mar 14, 2023
Merged

Require all CI jobs to pass, not one #736

bors merged 1 commit into from
Mar 14, 2023

Conversation

@syvb
Copy link
Member

@syvb syvb commented Mar 13, 2023

It turns out that bors interprets "Test Postgres (%)" as requiring at least one job to pass matching that, instead of all of them.

@syvb syvb requested review from WireBaron and thatzopoulos March 13, 2023 19:04
thatzopoulos
thatzopoulos approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@thatzopoulos thatzopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syvb
Copy link
Member Author

syvb commented Mar 14, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

Build succeeded:

@bors bors bot merged commit 97d4658 into main Mar 14, 2023
@bors bors bot deleted the sv/bors-all-jobs branch March 14, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WireBaron WireBaron Awaiting requested review from WireBaron

1 more reviewer

@thatzopoulos thatzopoulos thatzopoulos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syvb @thatzopoulos