Conversation
workingjubilee
left a comment
workingjubilee
left a comment
There was a problem hiding this comment.
Your current version on your main branch is likely fine but you will want to update to 0.9.7 instead due to a critical bug that affects 0.9.1, unfortunately.
syvb
force-pushed
the
sv/pgrx-0.9.1
branch
2 times, most recently
from
eb93356 to
ae22b99
Compare
| fn get_pgrx_version(cargo_toml_contents: &str) -> Version { | ||
| let cargo = cargo_toml_contents | ||
| .parse::<Document>() | ||
| .expect("invalid Cargo.toml"); | ||
|
|
||
| cargo["dependencies"]["pgx"] | ||
| cargo["dependencies"]["pgrx"] | ||
| .as_str() | ||
| .expect("expected pgx to only have a version") | ||
| .expect("expected pgrx to only have a version") | ||
| .trim_start_matches(['=', '^', '~'].as_slice()) | ||
| .parse() | ||
| .expect("cannot parse pgx version") | ||
| .expect("cannot parse pgrx version") | ||
| } |
There was a problem hiding this comment.
I think we might run into some issues with the update-tester here. After checking out a git tag, get_pgrx_version() will read the new Cargo.toml from the filesystem, which will still be listed as 'pgx' for all but this newest version which I think will cause a panic. I don't think any of the other update-tester changes should cause any problems.
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
4 participants
No description provided.