From 742a48c89f6a4ddbe578e8e2400d4c5f29f11dcb Mon Sep 17 00:00:00 2001
From: Zoltan Haindrich <zoltan@timescale.com>
Date: Fri, 17 Mar 2023 16:32:33 +0000
Subject: [PATCH] Fix segfault after column drop on compressed table

Decompression produces records which have all the decompressed data
set, but it also retains the fields which are used internally during
decompression.
These didn't cause any problem - unless an operation is being done
with the whole row - in which case all the fields which have ended up
being non-null can be a potential segfault source.

Fixes #5458 #5411
---
 CHANGELOG.md                             |  1 +
 tsl/src/nodes/decompress_chunk/exec.c    |  2 +-
 tsl/test/expected/compression_errors.out | 30 ++++++++++++++++++++++++
 tsl/test/sql/compression_errors.sql      | 18 ++++++++++++++
 4 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f423bfdf8fa..85a3e2861cc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,6 +29,7 @@ accidentally triggering the load of a previous DB version.**
 * #5499 Do not segfault on large histogram() parameters
 * #5497 Allow named time_bucket arguments in Cagg definition
 * #5500 Fix when no FROM clause in continuous aggregate definition
+* #5462 Fix segfault after column drop on compressed table
 
 **Thanks**
 * @nikolaps for reporting an issue with the COPY fetcher
diff --git a/tsl/src/nodes/decompress_chunk/exec.c b/tsl/src/nodes/decompress_chunk/exec.c
index eb5f40cba67..d0d633334df 100644
--- a/tsl/src/nodes/decompress_chunk/exec.c
+++ b/tsl/src/nodes/decompress_chunk/exec.c
@@ -473,7 +473,7 @@ decompress_chunk_create_tuple(DecompressChunkState *state)
 
 		if (!state->initialized)
 		{
-			ExecClearTuple(decompressed_slot);
+			ExecStoreAllNullTuple(decompressed_slot);
 
 			/*
 			 * Reset expression memory context to clean out any cruft from
diff --git a/tsl/test/expected/compression_errors.out b/tsl/test/expected/compression_errors.out
index ce600605367..270bad2654f 100644
--- a/tsl/test/expected/compression_errors.out
+++ b/tsl/test/expected/compression_errors.out
@@ -630,3 +630,33 @@ INSERT INTO ts_table SELECT * FROM data_table;
 --cleanup tables
 DROP TABLE data_table cascade;
 DROP TABLE ts_table cascade;
+--invalid reads for row expressions after column dropped on compressed tables #5458
+CREATE TABLE readings(
+    "time"  TIMESTAMPTZ NOT NULL,
+    battery_status  TEXT,
+    battery_temperature  DOUBLE PRECISION
+);
+INSERT INTO readings ("time") VALUES ('2022-11-11 11:11:11-00');
+SELECT create_hypertable('readings', 'time', chunk_time_interval => interval '12 hour', migrate_data=>true);
+NOTICE:  migrating data to chunks
+   create_hypertable    
+------------------------
+ (35,public,readings,t)
+(1 row)
+
+ALTER TABLE readings SET (timescaledb.compress,timescaledb.compress_segmentby = 'battery_temperature');
+SELECT compress_chunk(show_chunks('readings'));
+              compress_chunk              
+------------------------------------------
+ _timescaledb_internal._hyper_35_22_chunk
+(1 row)
+
+ALTER TABLE readings DROP COLUMN battery_status;
+INSERT INTO readings ("time", battery_temperature) VALUES ('2022-11-11 11:11:11', 0.2);
+SELECT readings FROM readings;
+               readings               
+--------------------------------------
+ ("Fri Nov 11 03:11:11 2022 PST",)
+ ("Fri Nov 11 11:11:11 2022 PST",0.2)
+(2 rows)
+
diff --git a/tsl/test/sql/compression_errors.sql b/tsl/test/sql/compression_errors.sql
index b196727d38e..a00487e59a5 100644
--- a/tsl/test/sql/compression_errors.sql
+++ b/tsl/test/sql/compression_errors.sql
@@ -364,3 +364,21 @@ INSERT INTO ts_table SELECT * FROM data_table;
 --cleanup tables
 DROP TABLE data_table cascade;
 DROP TABLE ts_table cascade;
+
+--invalid reads for row expressions after column dropped on compressed tables #5458
+CREATE TABLE readings(
+    "time"  TIMESTAMPTZ NOT NULL,
+    battery_status  TEXT,
+    battery_temperature  DOUBLE PRECISION
+);
+
+INSERT INTO readings ("time") VALUES ('2022-11-11 11:11:11-00');
+
+SELECT create_hypertable('readings', 'time', chunk_time_interval => interval '12 hour', migrate_data=>true);
+
+ALTER TABLE readings SET (timescaledb.compress,timescaledb.compress_segmentby = 'battery_temperature');
+SELECT compress_chunk(show_chunks('readings'));
+
+ALTER TABLE readings DROP COLUMN battery_status;
+INSERT INTO readings ("time", battery_temperature) VALUES ('2022-11-11 11:11:11', 0.2);
+SELECT readings FROM readings;