Remove redundant check in check_is_chunk_order_violated_by_merge#7783
Merged
svenklemm merged 1 commit intotimescale:mainfrom Mar 27, 2025
Merged
Remove redundant check in check_is_chunk_order_violated_by_merge#7783svenklemm merged 1 commit intotimescale:mainfrom
svenklemm merged 1 commit intotimescale:mainfrom
Conversation
svenklemm
force-pushed
the
remove_redundant_check
branch
from
4315707 to
d3ff379
Compare
svenklemm
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7783 +/- ##
==========================================
+ Coverage 80.06% 81.90% +1.84%
==========================================
Files 190 249 +59
Lines 37181 46050 +8869
Branches 9450 11532 +2082
==========================================
+ Hits 29770 37719 +7949
- Misses 2997 3784 +787
- Partials 4414 4547 +133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antekresic
reviewed
Mar 26, 2025
svenklemm
force-pushed
the
remove_redundant_check
branch
from
0948d59 to
068eb18
Compare
antekresic
approved these changes
Mar 27, 2025
svenklemm
force-pushed
the
remove_redundant_check
branch
2 times, most recently
from
5354763 to
0f555c4
Compare
We never hit this check and this is verified earlier, so we change it into an Ensure. Co-authored-by: Ante Kresic <antekresic@users.noreply.github.com> Signed-off-by: Sven Klemm <31455525+svenklemm@users.noreply.github.com>
svenklemm
force-pushed
the
remove_redundant_check
branch
from
0f555c4 to
2dd4b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant check in check_is_chunk_order_violated_by_merge
Disable-check: force-changelog-file
Disable-check: approval-count