Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch (0.215.2) Fails to open #16

Closed
lvalen91 opened this issue Apr 13, 2023 · 8 comments
Closed

Patch (0.215.2) Fails to open #16

lvalen91 opened this issue Apr 13, 2023 · 8 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@lvalen91
Copy link

Previous build (0.214.300) was updated without issue. This time around macOS immediately reports;
“Valheim” is damaged and can’t be opened. You should move it to the Trash.

Deleting Valheim folder and redownloading everything has no effect.macOS was updated between the last release and this one. The troubleshooting paths provided in readme don't have anything updated since previous patch. macOS Console logs provides some info, but I don't know if it's of value.

macOS 13.3.1 (22E261) on Intel i7 Mac mini
log.pdf

@lvalen91
Copy link
Author

Verified previous macOS 13.3(22E252) also does not open 0.215.2

This check was on an Intel MBP(2019) that hasn't yet been updated to macOS 13.3.1. It ran previous patch 0.214.300 without issue.

@timkurvers
Copy link
Owner

Hm, that's unfortunate. I see references to both ~/Desktop as well as potential external volumes under /Volumes/ in the log. I assume you have not changed where you build in the meantime?

Could you have a look at the output of xattr -rl build (from the root of the repository).

@timkurvers timkurvers added bug Something isn't working help wanted Extra attention is needed labels Apr 13, 2023
@lvalen91
Copy link
Author

I normally keep files on an external drive, but have been moving back and forth to rule out an external harddrive bottleneck.

Attached is the xattr output. This is from a fresh download of everything and kept within the Downloads folder of the main internal hard drive.

xattr_build_output.txt

@lvalen91
Copy link
Author

I was able to get a working game.

A lot of experimenting and no solid answer on what changed. I did notice a few things,

  • DepotDownloader can have an "InternalServer" error on certain chunks as it downloads the game. It won't stop the download, it won't redownload missing files when using the arg -validate. It finishes and states everything was downloaded.

Maybe it's a bad connection on my end.

  • Sometimes Unity doesn't get extracted correctly. Instead of a 7gig folder its 500mb.

  • SteamDb has a hash for each Depot, but there is no good or easy way to compare what's hosted and what you get.

  • On my MBP I did a fresh macOS. Which created a good stable Valheim on the first try.

Moving that entire "good" Folder to the Mac mini also builds a good game. However after MANY fresh GitHub downloads the macmini also created a good game.

Each time I thought I had it narrowed it down. Trying to get a consistent result was not successful. It's not this patch, I tried downloading older version and they each still failed to open.

I would consider this bug closed since a successful 0.215.2 Valheim.app was created at one point.

@timkurvers
Copy link
Owner

Thanks for the detailed report!

Just ouf of curiosity: did you clone the repository or download the code as an archive? Reason I am asking is that the xattr output contains Safari quarantine flags, which could prevent the app from launching.

Will give Safari + download-as-zip a try later this week.

@lvalen91
Copy link
Author

Zip was always my go to. I ran into an issue with cloning (I can’t remember) that I just never went back to figuring out.

I had also downloaded files individually

@timkurvers
Copy link
Owner

Just tested the Zip-download variant, made a build, and I also get the 'Valheim is damaged..'-message.

It does not address any of the other issues you have encountered, but removing the quarantine attributes with xattr -cr build (clear recursively) makes the app launchable again. Hopefully this helps for future builds of Valheim.

Will likely add a small note about this to the README this week.

@timkurvers timkurvers added documentation Improvements or additions to documentation and removed help wanted Extra attention is needed labels Apr 20, 2023
@timkurvers
Copy link
Owner

Added small note about quarantined downloads to the README in f2f4e7b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants