Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove double slash in form media #9

Merged
merged 1 commit into from

2 participants

@BrianHicks

If settings.STATIC_URL ends in a slash, it may raise a SuspiciousOperation error when run through tools like django-compressor. Removing trailing slashes from STATIC_URL fixes this.

@BrianHicks BrianHicks Remove double slash in form media
If `settings.STATIC_URL` ends in a slash, it may raise a `SuspiciousOperation` error when run through tools like django-compressor. Removing trailing slashes from STATIC_URL fixes this.
1f02063
@timmyomahony

Well spotted. Maybe I should actually rewrite the strings to %spagedown/Markdown.Converter.js (minus the starting slash) as the django docs recommend that the STATIC_URL always end in a slash? Although this way would ensure it works in both situtations

That's what I was thinking - I've worked on projects both ways. I think it's better to work with the complete range of input rather than hard-coding it in either direction. Principle of least astonishment and all that.

@timmyomahony timmyomahony merged commit 16f9f7c into timmyomahony:master
@timmyomahony
Owner

Agreed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 2, 2013
  1. @BrianHicks

    Remove double slash in form media

    BrianHicks authored
    If `settings.STATIC_URL` ends in a slash, it may raise a `SuspiciousOperation` error when run through tools like django-compressor. Removing trailing slashes from STATIC_URL fixes this.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 pagedown/widgets.py
View
6 pagedown/widgets.py
@@ -12,9 +12,9 @@ class Media:
css = {
'all': ('pagedown/demo/browser/demo.css',)
}
- js = ('%s/pagedown/Markdown.Converter.js' % settings.STATIC_URL,
- '%s/pagedown/Markdown.Sanitizer.js' % settings.STATIC_URL,
- '%s/pagedown/Markdown.Editor.js' % settings.STATIC_URL,)
+ js = ('%s/pagedown/Markdown.Converter.js' % settings.STATIC_URL.rstrip('/'),
+ '%s/pagedown/Markdown.Sanitizer.js' % settings.STATIC_URL.rstrip('/'),
+ '%s/pagedown/Markdown.Editor.js' % settings.STATIC_URL.rstrip('/'),)
def render(self, name, value, attrs=None):
if value is None:
Something went wrong with that request. Please try again.