[dbs-leipzig#1303] Fix PR comments

timo95 · Aug 8, 2019 · f2f881f · f2f881f
1 parent 93e3979
commit f2f881f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 20 deletions.
diff --git a/gradoop-flink/src/main/java/org/gradoop/flink/model/api/epgm/BaseGraphCollection.java b/gradoop-flink/src/main/java/org/gradoop/flink/model/api/epgm/BaseGraphCollection.java
@@ -28,8 +28,6 @@
 import org.gradoop.flink.model.impl.functions.graphcontainment.InGraph;
 import org.gradoop.flink.util.GradoopFlinkConfig;
 
-import java.util.Arrays;
-
 /**
  * Default interface of a graph collection instance.
  *
@@ -85,14 +83,6 @@ default LG getGraph(final GradoopId graphID) {
     return getGraphFactory().fromDataSets(graphHead, vertices, edges);
   }
 
-  @Override
-  default GC getGraphs(final GradoopId... identifiers) {
-    GradoopIdSet graphIds = new GradoopIdSet();
-    graphIds.addAll(Arrays.asList(identifiers));
-
-    return getGraphs(graphIds);
-  }
-
   @Override
   default GC getGraphs(final GradoopIdSet identifiers) {
     DataSet<G> newGraphHeads = this.getGraphHeads()

diff --git a/...op-flink/src/main/java/org/gradoop/flink/model/api/epgm/BaseGraphCollectionOperators.java b/...op-flink/src/main/java/org/gradoop/flink/model/api/epgm/BaseGraphCollectionOperators.java
@@ -92,8 +92,9 @@ public interface BaseGraphCollectionOperators<
    * @param identifiers graph identifiers
    * @return collection containing requested base graphs
    */
-  GC getGraphs(final GradoopId... identifiers);
-
+  default GC getGraphs(final GradoopId... identifiers) {
+    return getGraphs(GradoopIdSet.fromExisting(identifiers));
+  }
   /**
    * Extracts base graphs from collection using their identifiers.
    *
@@ -262,6 +263,7 @@ default DataSet<Boolean> equalsByGraphElementIds(GC otherCollection) {
    * indicates if the graph collection is equal to the given graph collection.
    * <p>
    * Equality is defined on the element data contained inside the collection, i.e. vertices and edges.
+   * This is limited to EPGM data (IDs, Label, Properties). All extensions of EPGM are ignored.
    *
    * @param otherCollection graph collection to compare with
    * @return 1-element dataset containing {@code true} if the two collections
@@ -279,6 +281,7 @@ default DataSet<Boolean> equalsByGraphElementData(GC otherCollection) {
    * indicates if the graph collection is equal to the given graph collection.
    * <p>
    * Equality is defined on the data contained inside the collection, i.e. graph heads, vertices and edges.
+   * This is limited to EPGM data (IDs, Label, Properties). All extensions of EPGM are ignored.
    *
    * @param otherCollection graph collection to compare with
    * @return 1-element dataset containing {@code true} if the two collections
@@ -304,8 +307,8 @@ default DataSet<Boolean> equalsByGraphData(GC otherCollection) {
   GC callForCollection(UnaryBaseGraphCollectionToBaseGraphCollectionOperator<GC> operator);
 
   /**
-   * Calls the given binary collection to value operator using that
-   * graph collection and the input graph collection.
+   * Calls the given binary collection to value operator using that graph collection and the
+   * input graph collection.
    *
    * @param operator        binary collection to value operator
    * @param otherCollection second input collection for operator
@@ -315,8 +318,8 @@ default DataSet<Boolean> equalsByGraphData(GC otherCollection) {
   <T> T callForCollection(BinaryBaseGraphCollectionToValueOperator<GC, T> operator, GC otherCollection);
 
   /**
-   * Calls the given binary collection to collection operator using that
-   * graph collection and the input graph collection.
+   * Calls the given binary collection to collection operator using that graph collection and the
+   * input graph collection.
    *
    * @param operator        binary collection to collection operator
    * @param otherCollection second input collection for operator
@@ -346,11 +349,10 @@ default GC apply(ApplicableUnaryBaseGraphToBaseGraphOperator<GC> operator) {
 
   /**
    * Transforms a graph collection into a base graph by applying a
-   * {@link org.gradoop.flink.model.api.operators.BinaryBaseGraphToBaseGraphOperator}
-   * pairwise on the elements of the collection.
+   * {@link ReducibleBinaryBaseGraphToBaseGraphOperator} pairwise on the elements of the collection.
    *
    * @param operator reducible binary graph to graph operator
-   * @return base graph
+   * @return base graph returned by the operator
    *
    * @see Exclusion
    * @see Overlap

diff --git a/...n/java/org/gradoop/flink/model/impl/operators/tostring/functions/ElementToDataString.java b/...n/java/org/gradoop/flink/model/impl/operators/tostring/functions/ElementToDataString.java
@@ -28,7 +28,7 @@
  * superclass of data-bases string representations of EPGM elements, i.e.,
  * such including label and properties
  *
- * @param <EL> EPGM element type
+ * @param <EL> element type
  */
 public abstract class ElementToDataString<EL extends Element> {