Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya Long Count #149

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@wtty-fool
Copy link
Contributor

wtty-fool commented Apr 22, 2018

Although Maya in name refers to Far East concept of maya, I thought it was ironic that it did not offer conversion to and from Maya Long Count calendar itself.

@@ -32,6 +32,22 @@ def test_iso8601(string, expected):
assert r == d.iso8601()


@pytest.mark.parametrize("string,expected", [
('January 1, 1970',
"12.17.16.7.5"),

This comment has been minimized.

Copy link
@wtty-fool

wtty-fool Apr 22, 2018

Author Contributor

You can validate it easily using using WolframAlpha, for example: https://www.wolframalpha.com/input/?i=January+1,+1970+to+maya+long+count

@timofurrer

This comment has been minimized.

Copy link
Owner

timofurrer commented May 8, 2018

I thought it was ironic that it did not offer conversion to and from Maya Long Count calendar itself.

Indeed it kinda is :)

However, I think to merge this we need an approval from @kennethreitz

@wtty-fool

This comment has been minimized.

Copy link
Contributor Author

wtty-fool commented Aug 28, 2018

Hi, @kennethreitz. I realize this playful PR is far from being a priority, but I'd appreciate any feedback 😉

@timofurrer timofurrer force-pushed the timofurrer:master branch 2 times, most recently from a583368 to a4432ee Aug 24, 2019
@timofurrer

This comment has been minimized.

Copy link
Owner

timofurrer commented Aug 24, 2019

Could you please resolve the conflicts? I'd be up for a merge :) 🎉

@wtty-fool wtty-fool force-pushed the wtty-fool:feature/maya-long-count branch from 4c95098 to 8493dd7 Sep 1, 2019
@wtty-fool

This comment has been minimized.

Copy link
Contributor Author

wtty-fool commented Sep 1, 2019

@timofurrer Done 👍

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Oct 31, 2019

This Pull Request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the state label Oct 31, 2019
@wtty-fool

This comment has been minimized.

Copy link
Contributor Author

wtty-fool commented Nov 3, 2019

@timofurrer A penny for your thoughs?

@timofurrer timofurrer merged commit 11c0d68 into timofurrer:master Nov 5, 2019
@timofurrer

This comment has been minimized.

Copy link
Owner

timofurrer commented Nov 5, 2019

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.