Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite duration does not work, toasts dismiss instantly #79

Closed
garand opened this issue May 8, 2021 · 7 comments
Closed

Infinite duration does not work, toasts dismiss instantly #79

garand opened this issue May 8, 2021 · 7 comments

Comments

@garand
Copy link

garand commented May 8, 2021

Hey! I saw this PR #37 and tried out a duration of Infinity, but it is just causing the toast to dismiss instantly.

I've put together a CodeSandbox that reproduces the behavior. Any ideas?

https://codesandbox.io/s/pedantic-framework-c3v0x?file=/src/App.js

@garand
Copy link
Author

garand commented May 8, 2021

Ah, it looks like there hasn't been a new version published since that. That would probably be why.

@joaopaulobdac
Copy link

@timolins Will we get a new release with this fix soon? 🙏

@timolins
Copy link
Owner

timolins commented May 20, 2021

You can try out react-hot-toast@2.0.0-beta.0 which includes this fix :) Will be publicly released after I gather some feedback.

@timolins
Copy link
Owner

Fix is out now with 2.0.0!

@shubham-mcsam
Copy link

The exact same issue of is occurring in 2.2.0

@timolins
Copy link
Owner

@shubham-mcsam Can you share an example that reproduces this issue?

@shubham-mcsam
Copy link

shubham-mcsam commented Apr 18, 2022

@timolins My bad, it's working as expected. I was writing Infinity as a string! Thanks for your work on the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants