Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-275: Propagate exceptions as a RuntimeException instead of java.lang.Error #281

Merged
merged 1 commit into from Jan 5, 2018

Conversation

@mjpitz
Copy link
Contributor

commented Jan 5, 2018

This should make it so that consumers can catch an Exception instead of any Error type.

@timols

This comment has been minimized.

Copy link
Owner

commented Jan 5, 2018

Easy. I thought you were going to create a new exception class. This works too :)

@timols timols merged commit 1b3dae4 into timols:master Jan 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@islandsvinur

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

Got hit by an Error today (was still on 4.0.0), upgraded to 4.1.0, then got hit again by a generic RuntimeException. Glad it no longer kills my thread, but I would prefer the API to throw IOException as declared. Maybe wrap it here in UncheckedIOException, then unwrap and rethrow?

@timols I'll create an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.