New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Prevent squishing of panes #15

Open
ProLoser opened this Issue Nov 7, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@ProLoser

ProLoser commented Nov 7, 2017

As per @mrleblanc101's comments on #12 I'm creating a new issue for separate discussion.

I think it would be nice if you could set a 'minimum' dimension in absolute value that a pane will be reduced to. This way you can try to resize a pane split to 90% / 10% but the smaller pane will not go below 200px.

I personally set my separation to around 60% so this isn't a big issue for me, but this seemed like a straightforward way to fix the problem for others.

The real problem is that you squish the content making it look really unpleasant and distracting.
There should be an absolute mode where the pane overlaps each other instead of being squished.
It also causes conflict with the minimal plugin as you can see in the screenshot below.

Then setting pane looks good because it's content doesn't get squished or wrapped over multiple lines

@benyanke

This comment has been minimized.

Show comment
Hide comment
@benyanke

benyanke Nov 8, 2017

I would also find this helpful.

benyanke commented Nov 8, 2017

I would also find this helpful.

@ProLoser

This comment has been minimized.

Show comment
Hide comment
@ProLoser

ProLoser Nov 8, 2017

Also to address @mrleblanc101's original issue, I think his problem could be fixed by simply disabling wrapping.

ProLoser commented Nov 8, 2017

Also to address @mrleblanc101's original issue, I think his problem could be fixed by simply disabling wrapping.

@benyanke

This comment has been minimized.

Show comment
Hide comment
@benyanke

benyanke Nov 8, 2017

Good idea! Is that something that plugins can modify on the fly, pane-by-pane? If so, that would completely solve the problem, at least in my usecase.

benyanke commented Nov 8, 2017

Good idea! Is that something that plugins can modify on the fly, pane-by-pane? If so, that would completely solve the problem, at least in my usecase.

@timomeh

This comment has been minimized.

Show comment
Hide comment
@timomeh

timomeh Nov 8, 2017

Owner

Because the issue is moved, I'll just copy my answer from the original Issue #12, including my bad wording.

That's not possible due to the way Panes work in Atom. The only way to not get squished content is by disabling soft wrap at the end of the Window and instead only wrap content at the 80char mark.

I checked the Docs of Panes in Atom if it's possible to disable wrapping per pane, but I didn't find anything.

Also I saw in my config file that the setting for Text Wrapping is scoped to editor (it's editor.softWrap and editor.softWrapAtPreferredLineLength), which also makes me believe this is only a global editor setting and not adjustable per Pane.

Maybe someone has an idea how to achieve it nevertheless?

Owner

timomeh commented Nov 8, 2017

Because the issue is moved, I'll just copy my answer from the original Issue #12, including my bad wording.

That's not possible due to the way Panes work in Atom. The only way to not get squished content is by disabling soft wrap at the end of the Window and instead only wrap content at the 80char mark.

I checked the Docs of Panes in Atom if it's possible to disable wrapping per pane, but I didn't find anything.

Also I saw in my config file that the setting for Text Wrapping is scoped to editor (it's editor.softWrap and editor.softWrapAtPreferredLineLength), which also makes me believe this is only a global editor setting and not adjustable per Pane.

Maybe someone has an idea how to achieve it nevertheless?

@benyanke

This comment has been minimized.

Show comment
Hide comment
@benyanke

benyanke Nov 8, 2017

Is it worth asking @atom to see if they'd be willing to implement pane-specific wrap overrides? That would seem to fit their goal of making the editor hackable.

benyanke commented Nov 8, 2017

Is it worth asking @atom to see if they'd be willing to implement pane-specific wrap overrides? That would seem to fit their goal of making the editor hackable.

@timomeh

This comment has been minimized.

Show comment
Hide comment
@timomeh

timomeh Nov 8, 2017

Owner

Opening a feature request is always a possibility, although I think supporting configs per pane is quite a big feature request. Also activating/deactivating soft wrap would only be a hack. For example, as you can see in the first screenshot of #15 (comment), the minimap is also squished, because the pane is so small.

We would need the possibility to let panes overlap, which also is quite a big feature request, because it would totally change the way how panes are positioned.

Owner

timomeh commented Nov 8, 2017

Opening a feature request is always a possibility, although I think supporting configs per pane is quite a big feature request. Also activating/deactivating soft wrap would only be a hack. For example, as you can see in the first screenshot of #15 (comment), the minimap is also squished, because the pane is so small.

We would need the possibility to let panes overlap, which also is quite a big feature request, because it would totally change the way how panes are positioned.

@ProLoser

This comment has been minimized.

Show comment
Hide comment
@ProLoser

ProLoser Nov 9, 2017

I think people shouldn't use such extreme percentages to begin with. I personally care more about animated resizing than this story lol

ProLoser commented Nov 9, 2017

I think people shouldn't use such extreme percentages to begin with. I personally care more about animated resizing than this story lol

@timomeh

This comment has been minimized.

Show comment
Hide comment
@timomeh

timomeh Nov 9, 2017

Owner

I personally use a "extreme" percentage, too, and I think many people also do.

Owner

timomeh commented Nov 9, 2017

I personally use a "extreme" percentage, too, and I think many people also do.

@benyanke

This comment has been minimized.

Show comment
Hide comment
@benyanke

benyanke Nov 9, 2017

I would use an extreme percentage, but I can't because the wrapping doesn't work, and I want to be able to at least see a bit of the small column's file without it scrolling down super far when it compresses. If there were wrap disabling, I'd use an extreme percentages in a heartbeat.

Just my 2c and my usecase.

benyanke commented Nov 9, 2017

I would use an extreme percentage, but I can't because the wrapping doesn't work, and I want to be able to at least see a bit of the small column's file without it scrolling down super far when it compresses. If there were wrap disabling, I'd use an extreme percentages in a heartbeat.

Just my 2c and my usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment