Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Thank you for your PR. While I don't have anything against dependencies, react-native-material-ui is quite a big dependency just to use their Badge.
Implementing a Badge without react-native-material-ui wouldn't be that hard, I think.
I would accept this PR without react-native-material-ui, but at the current state I can't justify shipping this with such a big dependency for one feature.
timomeh left a comment
Thank you for your PR, I love it!
Unfortunately it doesn't render correctly in Android, you can only see a quarter of the badge. This is because in Android everything is
Fortunately, you wrote pretty good code, so it's really easy to fix it and make it work in Android. I tried it locally and – instead of let you figure it out yourself – I commented the changes you need to do in order to support Android.