Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed badge animation #71
Conversation
ShayanJavadi
added some commits
Feb 4, 2018
This comment has been minimized.
This comment has been minimized.
|
Nice catch! Since I originally didn't test it in iOS, I didn't saw that there's an animation. Thank you |
timomeh
requested changes
Feb 11, 2018
| @@ -42,7 +44,8 @@ export default class Badge extends Component { | |||
| justifyContent: "center", | |||
| backgroundColor: "#F50057", | |||
| zIndex: 9999, | |||
| bottom: 10, | |||
| top: 3, | |||
| right: 27, | |||
This comment has been minimized.
This comment has been minimized.
timomeh
Feb 11, 2018
Owner
In an active Tab, this position causes the Badge to be far away from the Icon. This happens because it's a fixed value, but the position depends on the screen dimension, shifting, and Tab amount.
I would suggest something like left: '50%', marginLeft: 15. This way, it's positioned in the center of the Tab and then moved to the left. Looks like this:
Feel free to use a bigger/smaller value for marginLeft – depending on how you think it should be positioned.
This comment has been minimized.
This comment has been minimized.
ShayanJavadi
added some commits
Feb 11, 2018
timomeh
approved these changes
Feb 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Thank you! Going to merge it and do a patch release right now. |
ShayanJavadi commentedFeb 11, 2018
In my last pr I forgot that moving the renderBadge() method out of the renderIcon() method will cause it to lose the animation when you press on the tab. In this pr I've fixed that. the animation is now working properly for the badge