Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

useless and incorrect super() generated #40

Closed
jmvanel opened this Issue Mar 4, 2013 · 7 comments

Comments

Projects
None yet
2 participants

jmvanel commented Mar 4, 2013

In this example, title is transmitted by calling the ancestor constructor in the main constructor of BagWindow :

class BagWindow(var bag: Bag[_], title: String)
extends NarsFrame(title) with ActionListener with AdjustmentListener {

but scalagen generates an useless and incorrect super() ( line 53 ) :
super(title)

The Java source:
https://open-nars.googlecode.com/svn/trunk/nars/gui/BagWindow.java

The generated Scala :
https://open-nars.googlecode.com/svn/trunk/nars_core/src/main/scala/nars/gui/BagWindow.scala

timowest added a commit that referenced this issue Mar 4, 2013

Owner

timowest commented Mar 4, 2013

Could you provide a self contained test case for this issue?

jmvanel commented Mar 4, 2013

I was you did one .
Is this one a good test?
Do you still need my output ?

Owner

timowest commented Mar 5, 2013

Yes, my test didn't reproduce the problem.

jmvanel commented Mar 5, 2013

About the GNU GPL problem, what if I simply provide the original Java source without licence, and a few names changed ?

Owner

timowest commented Mar 5, 2013

If you have the copyright for the code, you could do that.

jmvanel commented Mar 5, 2013

OK, you're right on this.
I don't want to bother Dr Pei Wang with this.

I perfectly understand that you want to stick to LGPL.
However, AFAIK, nothing prevents some GPL license code to be reused as input in testing another software.
The executable part of Scalagen will no code from NARS.

timowest added a commit that referenced this issue Mar 5, 2013

timowest added a commit that referenced this issue Mar 5, 2013

Owner

timowest commented Mar 7, 2013

Released in 0.2.2

@timowest timowest closed this Mar 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment