Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add scala 2.10.0 as a cross build plus (and some minor changes) #17

Merged
merged 1 commit into from

5 participants

@fmpwizard
Collaborator
* Upgraded sbt to 0.12.1 because starting with scala 2.10.0, dependencies do not build for the minor bug fix version.
Meaning, the dependency for lift webkit for scala 2.10 is

net/liftweb/lift-webkit_2.10/2.5-M4/  (note that it is not 2.10.0 ) sbt 0.11.x does not know how to handle this, but sbt 0.12 does

* The web plugin version does not map to sbt version any more, so we are explicit about which one to use
* Added scala 2.10.0 as a cross build version of scala
@fmpwizard fmpwizard * Upgraded sbt to 0.12.1 because starting with scala 2.10.0, dependen…
…cies do not build for the minor bug fix version.

Meaning, the dependency for lift webkit for scala 2.10 is

net/liftweb/lift-webkit_2.10/2.5-M4/  (note that it is not 2.10.0 ) sbt 0.11.x does not know how to handle this, but sbt 0.12 does

* The web plugin version does not map to sbt version any more, so we are explicit about which one to use
* Added scala 2.10.0 as a cross build version of scala
f3421d6
@fmpwizard
Collaborator

As a side note, would you be interested on having your module be built with the other Lift's modules? (I know you said you have limited time, so this would actually free you from even publishing it, and I think all I would need to change is the version schema, where we would include the lift version and the module version (so we can cross build for the upcoming lift 3.0 as well as the 2.5 series.

Thanks!

@fmpwizard fmpwizard referenced this pull request
Closed

build for scala 2.10 #16

@timperrett
Owner

@fmpwizard thanks for the update, i'll merge it. I would consider it, but I would be reluctant to move the source code just yet. Are you suggesting just pulling it onto the lift jenkins? Lift is basically EOL for me, as im doing other stuff with my time now, so whilst I don't actively maintain / use this project, I get a fair number of enquires about it.

@timperrett timperrett merged commit cddccfa into from
@fmpwizard
Collaborator

@timperrett thanks for merging this. Having this module as part of the lift modules would not mean moving the source code, you still get to keep it here under your account, the only changes would be changing the version schema and then we would have the jenkins servers in cloudbees build and publish the snapshot version of this module, so, if you get more inquires/pull request or if you happen to have time and decide to add anything, as soon as you push them as you do now, they would get publish to sonatype. And then when Lift releases new versions, you don;t have to make any changes, we can take care of that as part of publishing the other modules.

BTW, I'm not sure if you saw the announcement, but the modules are not in the lift repository any more, they are on a separate repository, but regardless, we have already some modules that are still on their owner's github accounts and things have been working out pretty well.

Thanks

Diego

@timperrett
Owner

@fmpwizard Ok i'm down; that would be convenient for me. I was aware the code was not in lifts main project, I just prefer to stay external to the lift community these days :-) What do you need to get that working then? Pull request? :-P

@fmpwizard
Collaborator

Cool, I'll send a pull request in the next few days, thanks!

@d6y

Hi @timperrett, hi @fmpwizard

To take on the publishing, it looks like we'd need to add ourselves to https://issues.sonatype.org/browse/OSSRH-336 to be able to write into eu.getintheloop. I wanted to check here that Tim was OK with that for this particular module.

@timperrett
Owner

Hmm yes - that is true - i'm not wild about that at the moment... let me stew on it.

@dylemma

Has there been any activity w.r.t. publishing artifacts for 2.10? I am in the middle of trying to upgrade a project at work from Scala 2.9.1/Lift 2.4 to Scala 2.10.0/Lift 2.5-RC5(and eventually just 2.5 final), and it looks like lift-shiro is the only thing not published against scala 2.10.

@Chris81T

Is there any chance, that lift-shiro will be available soon to use it with the current release of scala 2.10 ? Like dylemma I'm also waiting for it to migrate from scala 2.9.2 to 2.10.

It would be perfect, if someone can finished the last step to provide the new version via some maven repository.

Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 19, 2013
  1. @fmpwizard

    * Upgraded sbt to 0.12.1 because starting with scala 2.10.0, dependen…

    fmpwizard authored
    …cies do not build for the minor bug fix version.
    
    Meaning, the dependency for lift webkit for scala 2.10 is
    
    net/liftweb/lift-webkit_2.10/2.5-M4/  (note that it is not 2.10.0 ) sbt 0.11.x does not know how to handle this, but sbt 0.12 does
    
    * The web plugin version does not map to sbt version any more, so we are explicit about which one to use
    * Added scala 2.10.0 as a cross build version of scala
This page is out of date. Refresh to see the latest.
View
2  project/build.properties
@@ -1 +1 @@
-sbt.version=0.11.3-2
+sbt.version=0.12.1
View
4 project/build.scala
@@ -11,7 +11,7 @@ object BuildSettings {
scalaVersion := buildScalaVersion,
scalaVersion := "2.9.2",
scalacOptions += "-deprecation",
- crossScalaVersions := Seq("2.9.1", "2.9.2"),
+ crossScalaVersions := Seq("2.9.1", "2.9.2", "2.10.0"),
resolvers ++= Seq(
ScalaToolsReleases,
"Shiro Releases" at "https://repository.apache.org/content/repositories/releases/",
@@ -64,7 +64,7 @@ object LiftShiroBuild extends Build {
lazy val library: Project = Project("lift-shiro", file("library"),
settings = BuildSettings.buildSettings ++ (
libraryDependencies ++= Seq(
- "net.liftweb" %% "lift-webkit" % "2.5-M3" % "compile",
+ "net.liftweb" %% "lift-webkit" % "2.5-M4" % "compile",
"org.apache.shiro" % "shiro-core" % "1.2.0",
"org.apache.shiro" % "shiro-web" % "1.2.0",
"commons-beanutils" % "commons-beanutils" % "20030211.134440"
View
2  project/plugins.sbt
@@ -1,3 +1,3 @@
resolvers += "web-plugin.repo" at "http://siasia.github.com/maven2"
-libraryDependencies <+= sbtVersion(v => "com.github.siasia" %% "xsbt-web-plugin" % (v+"-0.2.11.1"))
+libraryDependencies <+= sbtVersion(v => "com.github.siasia" %% "xsbt-web-plugin" % ("0.12.0-0.2.11.1"))
Something went wrong with that request. Please try again.