Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radar chart (new chart type) #25

Merged
merged 21 commits into from Sep 6, 2019

Conversation

@denisinvader
Copy link
Contributor

commented Sep 5, 2019

Related issue
#2

Example screenshot
radar chart examples


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@timqian

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

Thanks, @denisinvader , I will review this PR ASAP

It will be great if you can add some screenshots of the new chart; run npm run lint and fix the linting issues

This is the first chart type of PR, I have not set up PR requirements, sorry about that

@denisinvader

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

I have already run npm run lint and fixed all errors in src/Radar.js, but there are still some errors in other files.

radar chart example

I can provide more explanation about component options and more screenshots later. There are still some issues with labels positioning (on big-sized charts).

Does semi-opacity fit the style of the library?

@timqian

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

@denisinvader Thanks! The semi-opacity style looks great, is the PR ready for review?

@denisinvader

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@timqian yes, everything is ready

@timqian

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

LGTM

@timqian timqian merged commit 6e0f7cc into timqian:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.