New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badger support #41

Closed
jackmcgary opened this Issue Nov 29, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@jackmcgary
Copy link

jackmcgary commented Nov 29, 2018

Love this. Any plans for badger support? Anything you know of that would make it difficult to port? Thx.

@timshannon

This comment has been minimized.

Copy link
Owner

timshannon commented Nov 29, 2018

Yeah, I'd definitely love to add badger support. I've been debating whether or not to make it a separate library.

I think I'll see if I can integrate it without too much having to change.

@timshannon timshannon self-assigned this Nov 29, 2018

@nkev

This comment has been minimized.

Copy link

nkev commented Jan 14, 2019

+1 "Badgerhold" would go off, me thinks.

@thumbsized

This comment has been minimized.

Copy link

thumbsized commented Jan 18, 2019

+1 for badger. Bolt has blocking transactions(so you have to do batches to get sane performance) whereas badger does not. My latest testing was 250 bolt transactions vs 15 000 badger transactions per second.

@timshannon

This comment has been minimized.

Copy link
Owner

timshannon commented Jan 18, 2019

Alright I've opened up a new repository where I'll start on BadgerHold:

https://github.com/timshannon/BadgerHold

Follow the repo there for updates.

@timshannon

This comment has been minimized.

Copy link
Owner

timshannon commented Jan 30, 2019

I'm closing this issue, as BadgerHold looks ready for use currently. The master branch passes all tests, although there is one outstanding issue that I'm still working through, and hope to get resolved shortly.

I've also written up a comparison between BoltDB and Badger since I've had the opportunity to implement the exact same library on both databases.

https://tech.townsourced.com/post/boltdb-vs-badger/

@timshannon timshannon closed this Jan 30, 2019

@nkev

This comment has been minimized.

Copy link

nkev commented Jan 30, 2019

@timshannon Great article. I'm surprised about Badgers high memory consumption. My plan was to use multiple badger instances (one for each customer), but now I think I'll go back to BoltDB.

@timshannon

This comment has been minimized.

Copy link
Owner

timshannon commented Jan 30, 2019

You should read the exchange here: dgraph-io/badger#704 (comment)

The Dgraph guys themselves, don't seem to have any issues running multiple instances, so you might want to do your own testing to confirm for yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment