Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed multiple app notifications bug #7

Merged
merged 3 commits into from Oct 4, 2012

Conversation

Projects
None yet
2 participants

calonso commented Sep 21, 2012

No description provided.

calonso added some commits Sep 21, 2012

Fixed multiple application notifications
When there were multiple applications set up, all notifications were
sent as if belong to the first one.
fixed bug
As activerecord models from a join query are readonly, sent_at value
couldn't be set
Owner

timsu commented Sep 21, 2012

Can you fix the indentation? It doesn't look right.

calonso commented Sep 22, 2012

How do you prefer ir? One line?

Owner

timsu commented Sep 23, 2012

No, just in-line with the rest of the code. Maybe you're using tabs instead of spaces? If you go to the "Files Changed" tab in github you can see what i'm talking about.

calonso commented Oct 4, 2012

Hi. Indentation is already fixed. You can merge right now.

Owner

timsu commented Oct 4, 2012

awesome, thanks!

timsu added a commit that referenced this pull request Oct 4, 2012

Merge pull request #7 from calonso/master
Fixed multiple app notifications bug

@timsu timsu merged commit eb0934a into timsu:master Oct 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment