Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to dump monitor EDID. Fixes issue #35 #144

Merged
merged 2 commits into from Dec 2, 2015

Conversation

Projects
None yet
3 participants
@fallen
Copy link
Contributor

commented Dec 1, 2015

No description provided.

@fallen fallen force-pushed the fallen:hdmi_out_edid_dump branch from 10b5187 to efd2cb7 Dec 2, 2015

@fallen fallen force-pushed the fallen:hdmi_out_edid_dump branch from efd2cb7 to 79bb969 Dec 2, 2015

enjoy-digital added a commit that referenced this pull request Dec 2, 2015

Merge pull request #144 from fallen/hdmi_out_edid_dump
Add command to dump monitor EDID. Fixes issue #35

@enjoy-digital enjoy-digital merged commit 35cac62 into timvideos:master Dec 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enjoy-digital

This comment has been minimized.

Copy link
Member

commented Dec 2, 2015

thanks, merged.

@mithro

This comment has been minimized.

Copy link
Member

commented Dec 6, 2015

Bunch of general comments;

  • There is lots of code duplicated between both ports. Can you please refactor this to reduce the amount of duplication. For example, the code for reading the EDID should be shared between the ports. This could be using proper sharing or some type of templating.
  • There is lots of magic numbers and very little explanation going on in "void hdmi_out0_print_edid(void) {" function. Can you please refactor the code to include comments, links to further reading, etc.
  • The printing the EDID data to the console should be separate from the actual reading of the data.
@fallen

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2015

mithro added a commit that referenced this pull request Dec 25, 2018

Updating submodules.
 * litedram changed from da6fc8c to 81fa19e
    * 81fa19e - phy/usddrphy: fix DRC REQP-1665. <Florent Kermarrec>
    * c275755 - phy/usddrphy: add iodelay_clk_freq parameter <Florent Kermarrec>
    * 62a31de - phy: rename KUSDDRPHY to USDDRPHY since compatible with Kintex/Virtex Ultrascale <Florent Kermarrec>
    * e91366c - frontend/axi: use buffered SyncFIFO on datapath (reduce resource usage) <Florent Kermarrec>

 * liteeth changed from 52c2301 to d7fdcbb
    * d7fdcbb - phy: add Spartan6 RGMII PHY <Florent Kermarrec>

 * litex changed from v0.1-668-g1c1c1bd1 to v0.1-677-g291843ee
    *   291843ee - Merge pull request #144 from mithro/nextpnr-migen-update <Tim Ansell>
    |\
    | * 53731b79 - Integrate latest migen changes for lattice/icestorm. <Tim 'mithro' Ansell>
    * 180912a7 - build/sim: handle verilog $finish and if coverage is enabled, write report at the end of the simulation. <Florent Kermarrec>
    * b6c98cab - platforms/kcu105: change internal vref to 0.84v (recommended value for ddr4) <Florent Kermarrec>
    * ebe0d567 - bios/sdram: only show read delays when they are valid. <Florent Kermarrec>
    * 67a25902 - bios/sdram: reduce write leveling scan range <Florent Kermarrec>
    * fe5cef42 - soc/cores/clock: remove return on S7PLL.create_clkout <Florent Kermarrec>
    * eda1a83e - platforms/kcu105: set internal vref on ddr4 banks <Florent Kermarrec>
    * a27b5a3b - update Ultrascale DDRPHY <Florent Kermarrec>

Full submodule status
--
 6def7bc83dfb0338632e06a8b14c93faa6af8879 edid-decode (heads/master)
 a628956da7dc794e6e3c95b31ff9ce3af58bc763 flash_proxies (heads/master)
 81fa19e58d878a9d725086f3bb54aaed53cc6cde litedram (remotes/origin/HEAD)
 d7fdcbb1dc17d07852b1c9957d62f68d2dde29b5 liteeth (remotes/origin/HEAD)
 b29c3a07bc5e4e7eb8c12b174446b85371ffb3a0 litepcie (heads/master)
 b78a73110c0c26cf21bf1410329bf1e78286e929 litesata (heads/master)
 1634fa35bb9f2717ab355ca2e494e1d02fd489ec litescope (heads/master)
 0a9110f901182a1233cc4e64b6e39175f6784621 liteusb (heads/master)
 0993a4e0422454e522e1d2b491837034b8dcccbe litevideo (heads/master)
 291843ee76b43f8308cfdba21aa8a99c07327855 litex (v0.1-677-g291843ee)
 37db6bb52532b6d1c6bc8b724c2e8c6a38546c2a migen (0.6.dev-228-g37db6bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.