Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts #145

Merged
merged 2 commits into from Dec 22, 2015

Conversation

Projects
None yet
2 participants
@shenki
Copy link
Member

commented Dec 21, 2015

No description provided.

scripts/setup-env.sh: Set prompt when sourced
When sourced,

  shenki@icarus ~/dev/foo/HDMI2USB-misoc-firmware $

becomes:

  (HDMI2USB)shenki@icarus ~/dev/foo/HDMI2USB-misoc-firmware $

Signed-off-by: Joel Stanley <joel@jms.id.au>
@@ -127,3 +127,6 @@ echo ""
alias python=python3

export HDMI2USB_ENV=1

# Set prompt
PS1="(HDMI2USB)$PS1"

This comment has been minimized.

Copy link
@mithro

mithro Dec 21, 2015

Member

Maybe put the board/target in the prompt?

This comment has been minimized.

Copy link
@shenki

shenki Dec 21, 2015

Author Member

@mithro I had basename $PWD, but it made the prompt too big.

Will the user have the env variables for driving make set when running setup-env.sh?

This comment has been minimized.

Copy link
@mithro

mithro Dec 22, 2015

Member

Well, the prompt should probably evaluate them every time. I'll merge this now and we can make it better later.

Makefile.fx2: Correct script used in view target
Signed-off-by: Joel Stanley <joel@jms.id.au>

@shenki shenki force-pushed the shenki:fix-scripts branch from c7be735 to 667d6c5 Dec 21, 2015

mithro added a commit that referenced this pull request Dec 22, 2015

@mithro mithro merged commit e92a715 into timvideos:master Dec 22, 2015

1 of 2 checks passed

code-quality/landscape Landscape is checking code quality
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shenki shenki deleted the shenki:fix-scripts branch Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.