Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate a FRAMEBUFFERS_BASE for hdmi_inX #375

Merged
merged 6 commits into from Dec 30, 2017

Conversation

Projects
None yet
2 participants
@stefanor
Copy link
Contributor

commented Nov 26, 2017

We accidentally started using the same framebuffers for all inputs in 92eb6f9

@stefanor stefanor force-pushed the stefanor:hdmi-input-base branch from c93863e to d962f12 Nov 27, 2017

@@ -12,7 +12,7 @@
#include "uptime.h"
#include "version_data.h"

#define PATTERN_FRAMEBUFFER_BASE 0x02000000 + 0x100000
#define PATTERN_FRAMEBUFFER_BASE 0x00000000 + 0x100000

This comment has been minimized.

Copy link
@mithro

mithro Nov 27, 2017

Member

Pattern is now the first framebuffer? Can you add a comment about this?

This comment has been minimized.

Copy link
@stefanor

stefanor Nov 29, 2017

Author Contributor

Not sure what sort of comment you want. The commit message making this change describes it.
What is special enough about the first frame buffer that warrants a comment?

This comment has been minimized.

Copy link
@mithro

mithro Dec 8, 2017

Member

Maybe,

/* We store all the frame buffers at offset 0x0000000, the layout can be seen below;
 *
 *  0xX00000 - Pattern Frame Buffer
 * Each input then has 3 frame buffers spaced like this;
 *  0xX00000 - HDMI Input 0 - Frame Buffer n
 *  0xX00000 - HDMI Input 0 - Frame Buffer n+1
 *  0xX00000 - HDMI Input 0 - Frame Buffer n+2
@mithro

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

Does this have a bug associated with it?

@@ -19,8 +19,6 @@
int hdmi_in0_debug;

This comment has been minimized.

Copy link
@mithro

mithro Nov 27, 2017

Member

Should the firmware/hdmi_in0.c file be generated via the Makefile in some way now?

This comment has been minimized.

Copy link
@stefanor

stefanor Nov 29, 2017

Author Contributor

I don't see why?

@@ -22,6 +22,11 @@ FIRMWARE_DIR=$SCRIPT_DIR

X=$1

# parse the hex as an integer, for arithemtic purposes, then convert back to hex

This comment has been minimized.

Copy link
@mithro

mithro Nov 27, 2017

Member

Maybe it's just better to do a #define HDMI_IN_INDEX and then calculate the frame buffer value from that?

This comment has been minimized.

Copy link
@stefanor

stefanor Nov 29, 2017

Author Contributor

Yeah, that may be simpler. It'd probably have to be HDMI_IN0_INDEX etc.

@@ -12,7 +12,7 @@
#include "uptime.h"
#include "version_data.h"

#define PATTERN_FRAMEBUFFER_BASE 0x02000000 + 0x100000

This comment has been minimized.

Copy link
@mithro

mithro Nov 27, 2017

Member

It would be good if the 0x100000 part was a define somewhere. It's the rough size of the frame buffer right?

This comment has been minimized.

Copy link
@stefanor

stefanor Nov 29, 2017

Author Contributor

Who knows. I haven't seen a memory map.

Presumably the framebuffers are stored above this base, so I don't know what goes between 0x02000000 and the base.

@stefanor

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

Does this have a bug associated with it?

Yes, but not reported in a ticket. Fixing it was easy enough that I didn't bother.

@stefanor stefanor force-pushed the stefanor:hdmi-input-base branch from 46c47ba to 2d0be60 Dec 7, 2017

@mithro mithro force-pushed the stefanor:hdmi-input-base branch from 2d0be60 to 0d77955 Dec 30, 2017

@mithro mithro merged commit 1d5a391 into timvideos:master Dec 30, 2017

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stefanor stefanor deleted the stefanor:hdmi-input-base branch Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.