Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Colors work now! #397

Merged
merged 8 commits into from Jan 18, 2018

Conversation

Projects
None yet
4 participants
@mithro
Copy link
Member

commented Jan 18, 2018

No description provided.

jimmo and others added some commits Jan 17, 2018

Merge pull request #9 from jimmo/qemu-tftp-arch
Make qemu script work on Arch

@mithro mithro requested a review from rohitk-singh Jan 18, 2018

TFTP: Support alternate TFTP Server Port
If TFTP_SERVER_PORT is set in the environment, TFTP server will be
started on that port; if not, it is started on UDP/69 (well known
TFTP service port) as before.

If TFTP_SERVER_PORT is set in environment during build of litex
BIOS, then TFTP client will try to reach TFTP server on that port
first before falling back to UDP/69.

If TFTP_SERVER_PORT >= 1024 then TFTP server is started as user
without using sudo (otherwise sudo is used as before).

Tested with atftpd; in.tftpd equivalent added but not tested.
@rohitk-singh
Copy link
Member

left a comment

Works good! Yay!

@rohitk-singh

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

Err....log files now contain the color sequences

@mithro

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2018

@rohitk-singh Is that a problem?

@rohitk-singh

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

@mithro Not really. Just a compromise for much better build output

@mithro

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2018

You can view the logs with less -R and you still get colors :-P

Use non-privileged port by default
Less root is good...
@rohitk-singh

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

@mithro Wow, nice!

ewenmcneill and others added some commits Jan 18, 2018

TFTP: Run TFTP server without sudo by default
This also removes the "sudo which atftpd" command to avoid running
sudo just to find out where TFTP server is; instead we try "which atftpd"
(as user, not root), and then fall back to /usr/sbin/atftpd
Merge pull request #10 from ewen-naos-nz/tftp-alt-port
TFTP: Support alternate TFTP Server Port

@mithro mithro force-pushed the mithro:fix-colors branch from c9e2012 to ba0f8ea Jan 18, 2018

@mithro mithro merged commit ce63d43 into timvideos:master Jan 18, 2018

1 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details

@mithro mithro deleted the mithro:fix-colors branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.