New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Failing test(`TestGetPreviewPorts::test_get_preview_ports`) #176

Closed
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@software-opal
Copy link

software-opal commented Jan 21, 2015

This fixes the Integration test failures on TravisCI. It also adds an option to the Server class to output to stdout and stderr.

I also changed all the print statements to print functions(sorry - forgot about that when I was cleaning up).

@landscape-bot

This comment has been minimized.

Copy link

landscape-bot commented Jan 24, 2015

Code Health
Repository health decreased by 0.24% when pulling 27d761d on leesdolphin:fixing-preview-ports into 7856cc8 on timvideos:master.

@mithro

This comment has been minimized.

Copy link
Member

mithro commented Jan 30, 2015

@leesdolphin - I think we determined this sleep doesn't actually fix the issue on travis? Can you confirm?

@mithro

This comment has been minimized.

Copy link
Member

mithro commented Jan 30, 2015

@leesdolphin Can you split your other changes into a patch with correct comment and I'll merge them? They look good.

@mithro mithro closed this Jan 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment