New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs feature added #59

Merged
merged 13 commits into from Mar 12, 2014

Conversation

Projects
None yet
3 participants
@ApsOps
Copy link
Member

ApsOps commented Mar 11, 2014

As per this issue -- #18

@@ -25,6 +25,10 @@
url(r'^endpoint/logs$', views.endpoint_logs),
url(r'^endpoint/stats$', views.endpoint_stats),

# Endpoints for graphing.
url(r'^graphs$', views.overall_stats_graphs),

This comment has been minimized.

@mithro

mithro Mar 11, 2014

Member

This endpoint should probably be on the frontend instead.

@mithro

This comment has been minimized.

Copy link
Member

mithro commented Mar 11, 2014

Thanks for doing this!

I just noticed one problem with this change. Nothing in the /tracker directory should depend on code in the /frontend directory.

Either the graphs page should be moved to frontend directory, or the static files the graph page depends on should end up in the tracker directory.

@ApsOps

This comment has been minimized.

Copy link
Member

ApsOps commented Mar 11, 2014

Moved graphs code to frontend part. Please check.


# Endpoints for graphing.
url(r'^graphs$', views.overall_stats_graphs),
url(r'^overall-stats.json$', views.overall_stats_json),

This comment has been minimized.

@mithro

mithro Mar 11, 2014

Member

This json endpoint should remain in the tracker.

}

# Retrieve endpoints from within the requested data range.
recent_endpoints = models.Endpoint.objects.filter(

This comment has been minimized.

@mithro

mithro Mar 11, 2014

Member

Your not allowed to access the models directly from the frontend.

mithro added a commit that referenced this pull request Mar 12, 2014

@mithro mithro merged commit b175e6f into timvideos:master Mar 12, 2014

@mithro

This comment has been minimized.

Copy link
Member

mithro commented Mar 12, 2014

LGTM!

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment