Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin incompatible with Python 3.5 #3

Closed
tcitworld opened this issue Dec 15, 2019 · 5 comments
Closed

Plugin incompatible with Python 3.5 #3

tcitworld opened this issue Dec 15, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@tcitworld
Copy link

tcitworld commented Dec 15, 2019

This line makes use of an f-string which is only available with Python 3.6.

Sadly I can't have a newer Python version in my CI for now.

$ mkdocs -V
mkdocs, version 1.0.4 from /usr/local/lib/python3.5/dist-packages/mkdocs (Python 3.5)
$ mkdocs build
Traceback (most recent call last):
  File "/usr/local/bin/mkdocs", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/__main__.py", line 162, in build_command
    site_dir=site_dir
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/base.py", line 197, in load_config
    errors, warnings = cfg.validate()
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/base.py", line 107, in validate
    run_failed, run_warnings = self._validate()
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/base.py", line 62, in _validate
    self[key] = config_option.validate(value)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/config_options.py", line 132, in validate
    return self.run_validation(value)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/config_options.py", line 572, in run_validation
    plgins[item] = self.load_plugin(item, cfg)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/config/config_options.py", line 580, in load_plugin
    Plugin = self.installed_plugins[name].load()
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 2443, in load
    return self.resolve()
  File "/usr/local/lib/python3.5/dist-packages/pkg_resources/__init__.py", line 2449, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_git_revision_date_localized_plugin/plugin.py", line 33
    print(f"WARNING - plugin locale setting '{plugin_locale}' will overwrite mkdocs locale '{mkdocs_locale}'")
                                                                                                            ^
SyntaxError: invalid syntax
tcitworld added a commit to framasoft/mobilizon that referenced this issue Dec 16, 2019
So that CI may build the docs. See timvink/mkdocs-git-revision-date-localized-plugin#3

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@timvink
Copy link
Owner

timvink commented Dec 16, 2019

Thanks @tcitworld, you're right I should have supported python 2.7. Will release a new version later today and let you know.

@tcitworld
Copy link
Author

Many thanks !

@timvink
Copy link
Owner

timvink commented Dec 16, 2019

Just published v0.4. Retry your CI, or pip install --upgrade mkdocs-git-revision-date-localized-plugin

If it works please close the issue :)

@timvink timvink added the enhancement New feature or request label Dec 16, 2019
tcitworld added a commit to framasoft/mobilizon that referenced this issue Dec 16, 2019
And rebuild docker image with new version

See timvink/mkdocs-git-revision-date-localized-plugin#3

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
Copy link
Author

This issue seems to be fixed, unfortunately I now have the same as #2 (comment)

@timvink
Copy link
Owner

timvink commented Dec 16, 2019

The fix had a bug...should work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants