bump better-sqlite3 to v12 for Node 24 prebuilt support#25
Closed
galsakuri wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 54992aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This was referenced May 15, 2026
kulesy
added a commit
that referenced
this pull request
May 19, 2026
Pinning the floor to the version we actually tested and resolved against. The previous ^12.9.0 was inherited from #25 with no strong reason; consumers always resolve to the highest matching version (12.10.0) anyway, so the floor only matters for honest signalling. Updates package.json, lockfile importer spec, and the changeset text. No behavioural change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into tinacms/tinacms#6686 on a fresh Windows + Node 24 setup. npm install tinacms stalls trying to compile better-sqlite3 natively because ^11.8.1 (resolves to 11.10.0) has no prebuilt binary for win32/x64 on ABI 137. Bumping to ^12.9.0 picks up the prebuilt and the install completes cleanly.
No API changes needed in the sqlite-level source. The
Database,prepare,exec, anditeratecalls are all identical in v12. The lockfile just points to the new resolution.One thing worth flagging:
better-sqlite3@12drops Node 18 support (requires 20+). Node 18 went EOL in April 2025 so it probably doesn't matter, but flagging it in case TinaCMS still has users on it.