Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forms are neve registered in production #276

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@ncphillips
Copy link
Contributor

ncphillips commented Oct 9, 2019

Addresses some of the concern of #269

Not a complete fix

@ncphillips ncphillips added the perf label Oct 9, 2019
@ncphillips ncphillips requested a review from dwalkr Oct 9, 2019
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Oct 9, 2019

Warnings
⚠️

@tinacms/gatsby-tinacms-json may need new tests.

⚠️

@tinacms/react-tinacms-remark may need new tests.

⚠️

@tinacms/react-tinacms may need new tests.

Modified Packages

The following packages were modified by this pull request:

  • @tinacms/gatsby-tinacms-json
  • @tinacms/react-tinacms-remark
  • @tinacms/react-tinacms

Generated by 🚫 dangerJS against b337a84

@dwalkr
dwalkr approved these changes Oct 9, 2019
@ncphillips ncphillips merged commit 175ff1e into master Oct 9, 2019
2 checks passed
2 checks passed
build
Details
Danger Found some issues. Don't worry, everything is fixable.
Details
@ncphillips ncphillips deleted the perf-remove-forms-from-production branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.