Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git delete actions #901

Merged
merged 11 commits into from Mar 17, 2020
Merged

Git delete actions #901

merged 11 commits into from Mar 17, 2020

Conversation

@ncphillips
Copy link
Contributor

ncphillips commented Mar 17, 2020

Original PR by @mmintel

Hey there,

in order to fix #884 I've prepared a little PR for you. I hope this covers everything and solves it like intended.

I saw you are using conventional commits, I recommend to setup husky to check for that :)

Cheers
Marc

mmintel and others added 6 commits Mar 15, 2020
Unify DeleteAction API
@ncphillips ncphillips requested a review from tinacms/maintainers as a code owner Mar 17, 2020
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Mar 17, 2020

Warnings
⚠️ Update Docs for #901

Create Issue

Messages
📖 You can expect the changes in this PR to be published on 2020-3-1

Modified Packages

The following packages were modified by this pull request:

  • gatsby-tinacms-git
  • gatsby-tinacms-remark
  • gatsby-tinacms-json
  • gatsby-tinacms-mdx

Generated by 🚫 dangerJS against 2b42bf5

@ncphillips ncphillips added this to the 2020-03-23 Release milestone Mar 17, 2020
ncphillips added 5 commits Mar 17, 2020
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Mar 17, 2020

Size Change: 0 B

Total Size: 132 kB

ℹ️ View Unchanged
Filename Size Change
packages/@tinacms/api-git/build/index.js 4.27 kB 0 B
packages/@tinacms/core/build/index.js 836 B 0 B
packages/@tinacms/fields/build/index.js 5.51 kB 0 B
packages/@tinacms/form-builder/build/index.js 1.42 kB 0 B
packages/@tinacms/forms/build/index.js 1.67 kB 0 B
packages/@tinacms/git-client/build/index.js 1.45 kB 0 B
packages/@tinacms/icons/build/index.js 5.42 kB 0 B
packages/@tinacms/react-core/dist/index.js 146 B 0 B
packages/@tinacms/react-core/dist/react-core.cjs.production.min.js 927 B 0 B
packages/@tinacms/react-core/dist/react-core.esm.js 2.43 kB 0 B
packages/@tinacms/styles/build/index.js 2.51 kB 0 B
packages/@tinacms/teams/build/index.js 1.25 kB 0 B
packages/next-tinacms-json/dist/index.js 152 B 0 B
packages/next-tinacms-json/dist/next-tinacms-json.cjs.production.min.js 1.04 kB 0 B
packages/next-tinacms-json/dist/next-tinacms-json.esm.js 1.88 kB 0 B
packages/next-tinacms-markdown/dist/index.js 156 B 0 B
packages/next-tinacms-markdown/dist/next-tinacms-markdown.cjs.production.min.js 867 B 0 B
packages/next-tinacms-markdown/dist/next-tinacms-markdown.esm.js 1.63 kB 0 B
packages/react-dismissible/build/index.js 772 B 0 B
packages/react-tinacms-blocks/dist/index.js 155 B 0 B
packages/react-tinacms-blocks/dist/react-tinacms-blocks.cjs.production.min.js 2.68 kB 0 B
packages/react-tinacms-blocks/dist/react-tinacms-blocks.esm.js 4.05 kB 0 B
packages/react-tinacms-editor/dist/index.js 153 B 0 B
packages/react-tinacms-editor/dist/react-tinacms-editor.cjs.production.min.js 24.4 kB 0 B
packages/react-tinacms-editor/dist/react-tinacms-editor.esm.js 40.8 kB 0 B
packages/react-tinacms-inline/dist/index.js 153 B 0 B
packages/react-tinacms-inline/dist/react-tinacms-inline.cjs.production.min.js 2.53 kB 0 B
packages/react-tinacms-inline/dist/react-tinacms-inline.esm.js 3.87 kB 0 B
packages/react-tinacms/build/index.js 358 B 0 B
packages/tinacms/build/index.js 18.5 kB 0 B

compressed-size-action

@DirtyF
DirtyF approved these changes Mar 17, 2020
Copy link
Collaborator

DirtyF left a comment

LGTM

@dwalkr
dwalkr approved these changes Mar 17, 2020
@ncphillips ncphillips merged commit 2d762db into master Mar 17, 2020
7 checks passed
7 checks passed
build
Details
build (ubuntu-latest) build (ubuntu-latest)
Details
build
Details
build
Details
build (macOS-latest)
Details
build (windows-latest)
Details
Danger Found some issues. Don't worry, everything is fixable.
Details
@ncphillips ncphillips deleted the git-delete-actions branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.