New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0012998: Hammerjs does not load #6433

Closed
Gloirin opened this Issue Jun 9, 2018 · 12 comments

Comments

Projects
None yet
1 participant
@Gloirin

Gloirin commented Jun 9, 2018

Reported by schwigi on 2 May 2017 16:52

Version: 2017.02.3 Community Edition

On my new Windows 10 tablet hammerjs gets not loaded propperly. This results in the calendar and addressbook not working.

On the tablet this is reproducible on the tablet with Chrome, Edge and Firefox on Windows 10 and with Firefox running Ubuntu.

On all other systems I've tested (Windows 7, Windows 10, Ubuntu with Chrome and Firefox) all without a touchscreen.

Since my tablet is the only device with a touchscreen available and hammerjs is supposed to be a touch gesture library my guess is that this is reproducible on other touch screen devices as well.

Steps to reproduce: Use a device with a touchscreen and use the tine20 webinterface.

Additional information: The Server is running tine in a subdirectory

https://<servername>/tine20 on an Ubuntu 16.04 LTS

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin commented Jun 10, 2018

Related to #6643

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by ingoratsdorf on 3 May 2017 02:56

I can confirm the issue with windows10 on a SurfacePro3 and any browser.
I have all popup windows on my surface as modal windows even though I did select browser windows and they appear 2x or 3x on top of each other.
Using my laptop (same OS, same browsers) I get the standard browser windows and all work fine.

Gloirin commented Jun 11, 2018

Comment posted by ingoratsdorf on 3 May 2017 02:56

I can confirm the issue with windows10 on a SurfacePro3 and any browser.
I have all popup windows on my surface as modal windows even though I did select browser windows and they appear 2x or 3x on top of each other.
Using my laptop (same OS, same browsers) I get the standard browser windows and all work fine.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by mspahn on 3 May 2017 16:01

Are you running dev versions? In case you are not using our prebuild packages you need to run npm install inside Tinebase/js

Also please check your browser support:
http://hammerjs.github.io/browser-support/

Gloirin commented Jun 11, 2018

Comment posted by mspahn on 3 May 2017 16:01

Are you running dev versions? In case you are not using our prebuild packages you need to run npm install inside Tinebase/js

Also please check your browser support:
http://hammerjs.github.io/browser-support/

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by schwigi on 3 May 2017 16:34

I am running the packaged ubuntu version from xenial stable. So no current dev changes should be a problem.

The browsers I used (Desktop Firefox, Desktop Chrome) are all supported and should not result in a load error or strange behaviour without using touch gestures. Using an ASUS T101HA Tablet with Dock attached.

If it helps I can set up an npm version in parallel.

Gloirin commented Jun 11, 2018

Comment posted by schwigi on 3 May 2017 16:34

I am running the packaged ubuntu version from xenial stable. So no current dev changes should be a problem.

The browsers I used (Desktop Firefox, Desktop Chrome) are all supported and should not result in a load error or strange behaviour without using touch gestures. Using an ASUS T101HA Tablet with Dock attached.

If it helps I can set up an npm version in parallel.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by hobbyist on 14 Aug 2017 22:31

Hey, some TInebase/js-libraries, e.g. OpenLayers-f5fc191258fd529b739f-FAT.js or linkify, can't be loaded for me either. In my case, Tinebase/js is linked to the /-docroot-directory, whereas tine 2.0 is installed in a subdirectory-path. Maybe that's also your problem with hammerjs not working?!

Providing a /TInebase/js in the webserver's docroot-directory, is a ugly, but functional workaround. Maybe I try a rewrite.

Gloirin commented Jun 11, 2018

Comment posted by hobbyist on 14 Aug 2017 22:31

Hey, some TInebase/js-libraries, e.g. OpenLayers-f5fc191258fd529b739f-FAT.js or linkify, can't be loaded for me either. In my case, Tinebase/js is linked to the /-docroot-directory, whereas tine 2.0 is installed in a subdirectory-path. Maybe that's also your problem with hammerjs not working?!

Providing a /TInebase/js in the webserver's docroot-directory, is a ugly, but functional workaround. Maybe I try a rewrite.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by estradis on 18 Aug 2017 13:52

Problems with hammer.js also observed in https://forge.tine20.org/view.php?id=13142 (See screenshot)

Gloirin commented Jun 11, 2018

Comment posted by estradis on 18 Aug 2017 13:52

Problems with hammer.js also observed in https://forge.tine20.org/view.php?id=13142 (See screenshot)

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by hobbyist on 18 Aug 2017 14:22

But as you can see in post https://forge.tine20.org/view.php?id=13142 , this installation is also located in a subdirectory-path named /tine20

Gloirin commented Jun 11, 2018

Comment posted by hobbyist on 18 Aug 2017 14:22

But as you can see in post https://forge.tine20.org/view.php?id=13142 , this installation is also located in a subdirectory-path named /tine20

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by estradis on 24 Aug 2017 07:11

@hobbyist: Not sure what you want to tell me. What exactly is the problem and what exactly have I to do to fix it?

FYI:
We installed tine as described in https://wiki.tine20.org/Admins/Install_Howto on an ubuntu server. The path came from the original installation with apt. Tine is hosted in our dmz, but not accessible directly. It can only be reached through our reverse proxies with loadbalancers. Our webservers are hardened as well as the proxies with the loadbalancers.
We welcome the installation inside a subdirectory because it makes the configuration of the loadbalancers much easier. Konfigurations at root level is possible, but not recommend because it may break our hardening. (Our servers will only respond on the correct hostheaders AND subpaths. All other request will result into 403, 404, 410.)

Gloirin commented Jun 11, 2018

Comment posted by estradis on 24 Aug 2017 07:11

@hobbyist: Not sure what you want to tell me. What exactly is the problem and what exactly have I to do to fix it?

FYI:
We installed tine as described in https://wiki.tine20.org/Admins/Install_Howto on an ubuntu server. The path came from the original installation with apt. Tine is hosted in our dmz, but not accessible directly. It can only be reached through our reverse proxies with loadbalancers. Our webservers are hardened as well as the proxies with the loadbalancers.
We welcome the installation inside a subdirectory because it makes the configuration of the loadbalancers much easier. Konfigurations at root level is possible, but not recommend because it may break our hardening. (Our servers will only respond on the correct hostheaders AND subpaths. All other request will result into 403, 404, 410.)

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by hobbyist on 27 Aug 2017 08:43

Hi,
@estradis I don't want to give you an advice, I want to help solving the problem by describing the cause. I observed, that some JS-Files in that folder, where hammerjs resides, aren't adressed correctly by tine 2.0, when you using a subdir-installation, as it tries to load them from the webserver's root directoy, understandably failing with a 404 error. You referred to a ticket, whose screenshots supports my theory. As you recently added, you also use a subdir-installation for the ease of loadbalancing and reverse-proxying.

So, if you asked me for an advice or a quick fix, I would recommend you to think about whether you can afford/want (in your environment) to provide that /TInebase/js-directory additionally in https://yourdomain.org/Tinebase/js, cause that's the place your https://yourdomain.org/tine20/-installation is looking for those scripts, or try a rewrite of that paths.

Otherwise you have to wait, till the adressing of that components is fixed by the developers.

So, no offence meant, maybe that will help you to decide or solve your problems.

Gloirin commented Jun 11, 2018

Comment posted by hobbyist on 27 Aug 2017 08:43

Hi,
@estradis I don't want to give you an advice, I want to help solving the problem by describing the cause. I observed, that some JS-Files in that folder, where hammerjs resides, aren't adressed correctly by tine 2.0, when you using a subdir-installation, as it tries to load them from the webserver's root directoy, understandably failing with a 404 error. You referred to a ticket, whose screenshots supports my theory. As you recently added, you also use a subdir-installation for the ease of loadbalancing and reverse-proxying.

So, if you asked me for an advice or a quick fix, I would recommend you to think about whether you can afford/want (in your environment) to provide that /TInebase/js-directory additionally in https://yourdomain.org/Tinebase/js, cause that's the place your https://yourdomain.org/tine20/-installation is looking for those scripts, or try a rewrite of that paths.

Otherwise you have to wait, till the adressing of that components is fixed by the developers.

So, no offence meant, maybe that will help you to decide or solve your problems.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by estradis on 28 Aug 2017 12:07

Hi Hobbyist,

Now I almost feel a bit ashame because I didn't get it myself. (We had some infrastructure incidents in a HA environment, therefore the whole team had a lot of overload to troubleshoot. Maybe that was the reason.)

Thank you for your recommendation. I appreciate it! Your example looks very good. We should be able to uphold our hardening by using Tinebase as an alternate subpath. We'll investigate this and report as soon as we have the results.

Gloirin commented Jun 11, 2018

Comment posted by estradis on 28 Aug 2017 12:07

Hi Hobbyist,

Now I almost feel a bit ashame because I didn't get it myself. (We had some infrastructure incidents in a HA environment, therefore the whole team had a lot of overload to troubleshoot. Maybe that was the reason.)

Thank you for your recommendation. I appreciate it! Your example looks very good. We should be able to uphold our hardening by using Tinebase as an alternate subpath. We'll investigate this and report as soon as we have the results.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by estradis on 31 Aug 2017 15:18

Hi Hobbyist,

your recommendation works very good and our hardening is not broken.
(Details in https://forge.tine20.org/view.php?id=13142)

Thank you again. You made my day!

Gloirin commented Jun 11, 2018

Comment posted by estradis on 31 Aug 2017 15:18

Hi Hobbyist,

your recommendation works very good and our hardening is not broken.
(Details in https://forge.tine20.org/view.php?id=13142)

Thank you again. You made my day!

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by cweiss on 12 Jan 2018 08:53

same problem as #13430 should be fixed if it was still a problem for some

Gloirin commented Jun 11, 2018

Comment posted by cweiss on 12 Jan 2018 08:53

same problem as #13430 should be fixed if it was still a problem for some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment