0013350: Redis-Actionqueue isn't working anymore #6604

Closed
Gloirin opened this Issue Jun 9, 2018 · 4 comments

Comments

Projects
None yet
1 participant
@Gloirin

Gloirin commented Jun 9, 2018

Reported by hobbyist on 20 Jul 2017 17:22

Version: 2017.02.5 Community Edition

Jobs e.g. invitations are not sent via redis-actionqueue anymore. The execution of jobs failed and jobs are re

Additional information: Since your rework of the actionqueue's code in 0013220 until now (https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/blob/90d96d1143f7ccedbf554a86330578a43d1df456/tine20/Tinebase/ActionQueue/Worker.php) you do a check whether the function returns any other value than a boolean true: if (true !== ($result = Tinebase_ActionQueue::getInstance()->executeAction($job))) {

In class ActionQueue.php (https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/blob/master/tine20/Tinebase/ActionQueue.php#L135) you return the results of function call_user_func_array (return call_user_func_array(array($controller, $actionName), $message['params']);)

which according to the PHP-reference returns a boolean false, if an error occured, but a mixed result, if the function was executed correctly.

For example when you fork the Calendar.sendEventNotifications controller-method, you return void in method sendNotificationToAttender of class EventNotification (https://github.com/tine20/Tine-2.0-Open-Source-Groupware-and-CRM/blob/master/tine20/Calendar/Controller/EventNotifications.php#L270) which is passed back. The test of a boolean true fails and the job will be rescheduled.

So actually, ActionQueue isn't working for me any more.

Maybe the bevaviour described in issue #0011512 is caused by that bug.

Am I wrong or would be if (false === ($result = Tinebase_ActionQueue::getInstance()->executeAction($job))) the better solution? At least I got a success running the jobs (although I don't get mails - but maybe that's caused by my weird config).

@Gloirin Gloirin added this to the 2017.08.1 Community Edition milestone Jun 9, 2018

@Gloirin Gloirin self-assigned this Jun 9, 2018

@Gloirin Gloirin closed this Jun 9, 2018

@Gloirin

This comment has been minimized.

Show comment
Hide comment

Gloirin commented Jun 10, 2018

Related to #5696

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 21 Jul 2017 07:55

thanks for the report, we'll have a look!

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 21 Jul 2017 07:55

thanks for the report, we'll have a look!

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by hobbyist on 29 Jul 2017 12:10

issues 0011512 and 0013350 are now discussed in the forum on topic https://www.tine20.org/forum/viewtopic.php?f=12&t=18506

Why Mail weren't sent was simply because I forgot to install a postfix after changing my Server. :-(
Nevertheless the actionsqueue's success checks should be reviewed.

Gloirin commented Jun 11, 2018

Comment posted by hobbyist on 29 Jul 2017 12:10

issues 0011512 and 0013350 are now discussed in the forum on topic https://www.tine20.org/forum/viewtopic.php?f=12&t=18506

Why Mail weren't sent was simply because I forgot to install a postfix after changing my Server. :-(
Nevertheless the actionsqueue's success checks should be reviewed.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pmehrer on 2 Aug 2017 15:03

thanks for reporting this. The code in that region has changed in the meantime, so this issue is not present anymore

best regards
Paul

Gloirin commented Jun 11, 2018

Comment posted by pmehrer on 2 Aug 2017 15:03

thanks for reporting this. The code in that region has changed in the meantime, so this issue is not present anymore

best regards
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment