Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
0013526: Calendar ICS import can't cope with floating time #6691
Reported by ingoratsdorf on 6 Oct 2017 06:03
Version: git master
Imported events from a booking calendar do not contain organizers (as there are none) and are in local UTC+12 (NZDT).
Gets imported for the 7. October at 4am.
Steps to reproduce: Import calendar.
Comment posted by ingoratsdorf on 7 Oct 2017 09:21
However the Abstract VCalendar converter uses Sabre\VObject\Property\ICalendar\DateTime->getDateTime(); which returns all floating dates with a UTC timezone attached. This should be the local time.
Fixed Tinebase->Convert->VCalendar->Abstract.php code snippet:
Comment posted by pschuele on 9 Oct 2017 07:10
hm, we have a failing test. it looks like the TZ isn't detected any more ...
Comment posted by ingoratsdorf on 13 Oct 2017 09:55
I fixed the timezone issue meanwhile, however struggle big time with the organizer issue.
Comment posted by pschuele on 16 Oct 2017 07:26
> How do you import a, say, holiday calendar without being added as attendee and organizer and your time shown blocked. That's just plain silly.
I'll ask Cornelius about that, maybe he has a good suggestion how to solve this.
Comment posted by ingoratsdorf on 20 Mar 2018 09:27
Houston, we have a regression.
My patch has not been included and as I have replaced my installation of tine20 with a snapshot of GIT, the issue is back again. My patch fixes the issue for me, but not sure why the TZID=Asia/Tehran fails (Import/files/lightning_TehranTZ.ics) when the test with Lightings bad TZ (Import/files/lightning_badTZ.ics) apparently goes through correctly.
Comment posted by cweiss on 19 Apr 2018 15:22
here is the fix for the floating thing (also attached)
For the organiser/attendee there should already be an issue somewhere here. if not feel free to open one.