0013582: Tine sends an invalid VTODO during sync, when a task is marked as done #6718

Closed
Gloirin opened this Issue Jun 9, 2018 · 5 comments

Comments

Projects
None yet
1 participant
@Gloirin

Gloirin commented Jun 9, 2018

Reported by lhitc on 25 Oct 2017 18:12

Version: 2017.08.8 Community Edition

I'm using DAVdroid for syncing my Android device with Tine.
When I mark a task as done in the Tine web UI, that is not synced to the device.
Marking the task as done on the Android device syncs fine.
Everything else is also syncing fine.

I first reported this as a bug to DAVdroid, but apparently Tine is the source of the problem for being non-conformant to the relevant RFC.
For details see https://forums.bitfire.at/topic/1567/marking-a-task-as-done-doesn-t-sync-from-tine-2-0-server-to-phone

Steps to reproduce: 1. create an unfinished task in the Tine web UI
2. sync CalDAV data to the Android device (sync app is DAVdroid, Google Playstore version)
3. the task appears correctly on the Android device
4. set the task to "done" in the Tine web UI
5. sync again
6. the task is still marked as unfinished

Additional information: Please note that changing the Android DAV sync app is not an option, since DAVdroid is currently the only one working correctly in background with Android 7.

@Gloirin Gloirin added this to the 2017.08.9 Community Edition milestone Jun 9, 2018

@Gloirin Gloirin self-assigned this Jun 9, 2018

@Gloirin Gloirin closed this Jun 9, 2018

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by ingoratsdorf on 25 Oct 2017 19:26

Hi,
I can confirm that Tine20 sets the COMPLETED property incorrectly as a local time with TZID. According to the spec, this should be in UTC, unlike DUE which should be local if the DTSTART is local. I'd call this inconsistency, but that's what it is.
COMPLETED Ref: https://tools.ietf.org/html/rfc5545#section-3.8.2.1
DUE Ref: https://tools.ietf.org/html/rfc5545#section-3.8.2.3

Interestingly enough, it passes iCalendar validator.
Ref: https://icalendar.org/validator.html#results

I believe the fix is easy and I'll try to get this done ASAP.

Gloirin commented Jun 11, 2018

Comment posted by ingoratsdorf on 25 Oct 2017 19:26

Hi,
I can confirm that Tine20 sets the COMPLETED property incorrectly as a local time with TZID. According to the spec, this should be in UTC, unlike DUE which should be local if the DTSTART is local. I'd call this inconsistency, but that's what it is.
COMPLETED Ref: https://tools.ietf.org/html/rfc5545#section-3.8.2.1
DUE Ref: https://tools.ietf.org/html/rfc5545#section-3.8.2.3

Interestingly enough, it passes iCalendar validator.
Ref: https://icalendar.org/validator.html#results

I believe the fix is easy and I'll try to get this done ASAP.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by ingoratsdorf on 28 Oct 2017 08:08

Created tine20#34

Gloirin commented Jun 11, 2018

Comment posted by ingoratsdorf on 28 Oct 2017 08:08

Created tine20#34

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 12:57

thanks for the PR. we'll review that soon.

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 12:57

thanks for the PR. we'll review that soon.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 13:01

https://gerrit.tine20.com/customers/6321

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 13:01

https://gerrit.tine20.com/customers/6321

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 13:48

change has been merged :)

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 13:48

change has been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment