0013584: Enhancement of 0011236: Smtp-Backend simpleMail should remove remaining user data #6719

Closed
Gloirin opened this Issue Jun 9, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@Gloirin

Gloirin commented Jun 9, 2018

Reported by lab-at-nohl on 26 Oct 2017 12:29

Version: 2017.08.8 Community Edition

SimpleMail is used to store additional mail routing data in LDAP outside user�s DN. In default configuration: mailAlternateAddress, mailForwardingAddress and mailDiscard. This is especially handy if mail settings originate from an other tool (which may use different attribute�s name than default configuration).

If the user�s Account is deleted the mail routing data remain because it is outside the removed DN. I guess that is why the trigger �inspectDeleteUser� isn�t implemented in LDAP-Plugins.

My last pull request tine20#30 connects the trigger and execute it as inherited function wehen user gets deleted.

Additional information: I put the changes into two different commits that you can evaluate commit a002438 separately because this changes Tinebase/User/Ldap.php and Tinebase/User/Plugin/LdapAbstract.php slightly. The reason is that ldap plugins (sync backends) didn't offer a trigger if an user is deleted (unlike SQL backends do). I added one hopefully in a way that does not interfere with the other plugins: The added function is limited to an empty abstract of class, therefore only those classes which need it may inherit the additional function (other Plugins stay untouched).

I think the nature of change makes it a candidate for a late minor update.

@Gloirin

This comment has been minimized.

Show comment
Hide comment

Gloirin commented Jun 10, 2018

Related to #5560

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 16:12

hi Johannes, thanks for your PR (tine20#30).

we'll put that into the gerrit for autmated testing and will review it soon.

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 16:12

hi Johannes, thanks for your PR (tine20#30).

we'll put that into the gerrit for autmated testing and will review it soon.

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 16:19

http://gerrit.tine20.com/customers/6325

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 9 Nov 2017 16:19

http://gerrit.tine20.com/customers/6325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment