New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0013836: ActiveSync folder type not working for custom Trash folder #6842

Closed
Gloirin opened this Issue Jun 9, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Gloirin

Gloirin commented Jun 9, 2018

Reported by psieg on 23 Apr 2018 15:19

Version: 2018.02.3 Community Edition

I am running a setup where the Trash and Sent folders have custom names ('Gelöschte Elemente' from Outlook in German). Felamimail supports these, but reports them incorrectly via ActiveSync because the corresponding check is below the switch (strtoupper($folder->localname)). This effectively allows only custom folders at different locations, say INBOX.something.Trash.

Steps to reproduce: - Setup an account with an E-Mail Account

  • Specify a custom Trash folder, such as 'Deleted Items'
  • Ensure there is no folder named trash
  • Create a corresponding account on your mobile device and log the XML traffic for the FolderHierarchy request:
    <?xml version="1.0" encoding="utf-8"?>
    <!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
    <FolderSync xmlns="uri:FolderHierarchy">
    <SyncKey>0</SyncKey>
    </FolderSync>

Actual Response:
<!DOCTYPE AirSync PUBLIC "-//AIRSYNC//DTD AirSync//EN" "http://www.microsoft.com/">
<FolderSync xmlns="uri:FolderHierarchy" xmlns:Syncroton="uri:Syncroton" xmlns:Internal="uri:Internal">
<Status>1</Status>
<SyncKey>1</SyncKey>
<Changes>
<Count>41</Count>
<Add>
<ServerId>5</ServerId>
<ParentId>0</ParentId>
<DisplayName>User Name's personal calendar</DisplayName>
<Type>8</Type>
</Add>
<Add>
<ServerId>3</ServerId>
<ParentId>0</ParentId>
<DisplayName>User Name's personal addressbook</DisplayName>
<Type>9</Type>
</Add>
<Add>
<ServerId>04828f697f3eb14b2cc6edc4e879be8bb42a1623</ServerId>
<ParentId>0</ParentId>
<DisplayName>INBOX</DisplayName>
<Type>2</Type>
</Add>
<Add>
<ServerId>31e259d55c7a7e01ec6fcf03c0b660bfa0673fc9</ServerId>
<ParentId>04828f697f3eb14b2cc6edc4e879be8bb42a1623</ParentId>
<DisplayName>Deleted Items</DisplayName>
<Type>12</Type>
</Add>
<Add>
<ServerId>fake-3</ServerId>
<ParentId>0</ParentId>
<DisplayName>Drafts</DisplayName>
<Type>3</Type>
</Add>
<Add>
<ServerId>fake-4</ServerId>
<ParentId>0</ParentId>
<DisplayName>Trash</DisplayName>
<Type>4</Type>
</Add>
<Add>
<ServerId>fake-5</ServerId>
<ParentId>0</ParentId>
<DisplayName>Sent</DisplayName>
<Type>5</Type>
</Add>
<Add>
<ServerId>fake-6</ServerId>
<ParentId>0</ParentId>
<DisplayName>Outbox</DisplayName>
<Type>6</Type>
</Add>
</Changes>
</FolderSync>

The folder 'Deleted Items' should have Type 4, and there should not be a fake-4 'Trash' folder.

I identified the cause and proposed a fix in #49

Additional information: The E-Mail account is setup with INBOX. personal prefix, i.e. the Trash folder name is 'INBOX.Deleted Items'

@Gloirin Gloirin added this to the 2018.02.4 Community Edition milestone Jun 9, 2018

@Gloirin Gloirin self-assigned this Jun 9, 2018

@Gloirin Gloirin closed this Jun 9, 2018

@Gloirin

This comment has been minimized.

Show comment
Hide comment
@Gloirin

Gloirin Jun 11, 2018

Comment posted by pschuele on 3 May 2018 13:39

pull request has been merged. thanks!

Gloirin commented Jun 11, 2018

Comment posted by pschuele on 3 May 2018 13:39

pull request has been merged. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment